Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-pms
Navigation:
Lists: gentoo-pms: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-pms@g.o
From: Ulrich Mueller <ulm@g.o>
Subject: Re: apply_user_patches
Date: Mon, 7 May 2012 20:16:30 +0200
>>>>> On Mon, 7 May 2012, Michał Górny wrote:

> On Mon, 07 May 2012 12:19:40 -0400
> Michael Orlitzky <michael@...> wrote:

>> > After all, this functionality is just a stop-gap measure for users
>> > to apply quick bug fixes, so I don't expect that it will be used
>> > very often. Even fewer cases will require that eautoreconf is
>> > called. Do we really want to force developers to put this function
>> > call into every ebuild? That would be out of proportion, IMHO.
>> 
>> Only the ebuilds that override src_prepare (which is a lot).

> The reason for src_prepare() was to simplify ebuilds (so they don't
> have to override whole src_unpack()). Requiring a specific line in
> every src_prepare() call means going the other way.

+1

Also, if we add the feature to EAPI 5, we won't get anything close to
100% coverage for a very long time. (Looking at usage statistics, EAPI
2 was introduced almost 4 years ago, and about 30% of the tree are
still at EAPI 0 or 1.)

Couldn't the PM call a user-supplied script (which would be a file
with a special name placed in the same directory) after applying the
user patches? Since this script could do any postprocessing required,
applying user patches could be postponed until after src_prepare.

Ulrich


Replies:
Re: apply_user_patches
-- Ciaran McCreesh
References:
EAPI 5 development branch
-- Ciaran McCreesh
apply_user_patches (was: EAPI 5 development branch)
-- Ulrich Mueller
Re: apply_user_patches (was: EAPI 5 development branch)
-- Ciaran McCreesh
Re: apply_user_patches (was: EAPI 5 development branch)
-- Ulrich Mueller
Re: apply_user_patches
-- Michael Orlitzky
Re: apply_user_patches
-- Michał Górny
Navigation:
Lists: gentoo-pms: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: apply_user_patches
Next by thread:
Re: apply_user_patches
Previous by date:
Re: apply_user_patches
Next by date:
Re: apply_user_patches


Updated Jul 18, 2012

Summary: Archive of the gentoo-pms mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.