Re: [gentoo-portage-dev] [PATCH] portage/util.py: Identify the source of a "bad sustitution" error message (bug 542796)

[Zac Medico]

On 04/23/2015 11:08 AM, Brian Dolbec wrote:
> On Thu, 23 Apr 2015 10:38:24 -0700
> Zac Medico <zmedico@g.o> wrote:
>
>> On 04/23/2015 09:01 AM, Brian Dolbec wrote:
>>> This bug caused great difficulty in determining the cause of the
>>> error message. This adds identifying code which states where the
>>> error message is coming from. It also adds the actual source which
>>> caused the error message in the first place. X-Gentoo-Bug: 542796
>>> X-Gentoo-Bug-url: https://bugs.gentoo.org/show_bug.cgi?id=542796
>>> X-Gentoo-forum-thread:
>>> https://forums.gentoo.org/viewtopic-t-1014842.html
>>
>> Since varexpand already has an error_leader argument, we could use
>> that to report the source. The relevant varexpand calls are in
>> pym/portage/util/_dyn_libs/LinkageMapELF.py, added in commit
>> f1c1b8a77eebf7713b32e5f9945690f60f4f46de.
>
>
> Yes, that is a good idea.  Should we do similar for all varexpand calls?

Sure. Most varexpand calls are via portage.util.getconfig, which already
passes in the error_leader parameter. There are a small number of
varexpand calls elsewhere which aren't using the error_leader parameter yet.

> Also, That is in addition to identifying that the message is being
> generated in portage.util varexpand()?  So we don't keep looking for
> the problem/source in the wrong place like we just did?

I think it's enough to use the error_leader parameter, since generally
that should give enough information to isolate the source of the problem.
-- 
Thanks,
Zac