Gentoo Archives: gentoo-portage-dev

From: "i.Dark_Templar" <darktemplar@×××××××××××××××××××××.net>
To: gentoo-portage-dev@l.g.o
Cc: "i.Dark_Templar" <darktemplar@×××××××××××××××××××××.net>
Subject: [gentoo-portage-dev] [PATCH] Don't modify /etc/mtab from temporary namespaces
Date: Mon, 27 May 2019 20:26:08
Message-Id: 20190527202318.8032-1-darktemplar@dark-templar-archives.net
1 These records are never removed and just pollute
2 /etc/mtab if that's a regular file.
3 And if /etc/mtab isn't a regular file,
4 then attempts to modify it are pointless.
5 ---
6 lib/portage/process.py | 2 +-
7 1 file changed, 1 insertion(+), 1 deletion(-)
8
9 diff --git a/lib/portage/process.py b/lib/portage/process.py
10 index 0dba55de3..dfbda75de 100644
11 --- a/lib/portage/process.py
12 +++ b/lib/portage/process.py
13 @@ -617,7 +617,7 @@ def _exec(binary, mycommand, opt_name, fd_pipes,
14 os._exit(1)
15 # mount new /proc for our namespace
16 s = subprocess.Popen(['mount',
17 - '-t', 'proc', 'proc', '/proc'])
18 + '-n', '-t', 'proc', 'proc', '/proc'])
19 mount_ret = s.wait()
20 if mount_ret != 0:
21 writemsg("Unable to mount new /proc: %d\n" % (mount_ret,),
22 --
23 2.21.0

Replies