Gentoo Archives: gentoo-portage-dev

From: Michael Palimaka <kensington@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Michael Palimaka <kensington@g.o>
Subject: [gentoo-portage-dev] [PATCH 2/3] install-qa-check.d/05double-D: Write to log and improve consistency.
Date: Sat, 25 Oct 2014 16:17:51
Message-Id: 1414253761-6310-2-git-send-email-kensington@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions. by Michael Palimaka
1 Present the list of offending files newline-delimitered for consistency
2 with other checks.
3 ---
4 bin/install-qa-check.d/05double-D | 3 ++-
5 1 file changed, 2 insertions(+), 1 deletion(-)
6
7 diff --git a/bin/install-qa-check.d/05double-D b/bin/install-qa-check.d/05double-D
8 index 1634afd..84fcc89 100644
9 --- a/bin/install-qa-check.d/05double-D
10 +++ b/bin/install-qa-check.d/05double-D
11 @@ -2,9 +2,10 @@
12
13 DD_check() {
14 if [[ -d ${D%/}${D} ]] ; then
15 + eqawarn "QA Notice: files installed in \${D}/\${D}:"
16 local -i INSTALLTOD=0
17 while read -r -d $'\0' i ; do
18 - eqawarn "QA Notice: /${i##${D%/}${D}} installed in \${D}/\${D}"
19 + eqawarnlog double-d "/${i##${D%/}${D}}"
20 ((INSTALLTOD++))
21 done < <(find "${D%/}${D}" -print0)
22 die "Aborting due to QA concerns: ${INSTALLTOD} files installed in ${D%/}${D}"
23 --
24 2.0.4

Replies