Re: [gentoo-portage-dev] [PATCH] repoman: Remove http compatibility code for metadata DTD

[Zac Medico]

On 1/25/22 08:44, Ulrich Müller wrote:

> Commit 3950d76df says: "The http:// compat can be removed once the
> Gentoo repository is updated to use https:// everywhere."
>
> Bug: https://bugs.gentoo.org/552720
> Signed-off-by: Ulrich Müller <ulm@g.o>
> ---
>   repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py b/repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py
> index b4e0ee933..0fb97a0df 100644
> --- a/repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py
> +++ b/repoman/lib/repoman/modules/scan/metadata/pkgmetadata.py
> @@ -127,7 +127,7 @@ class PkgMetadata(ScanBase, USEFlagChecks):
>               )
>           else:
>               doctype_system = _metadata_xml.docinfo.system_url
> -            if doctype_system.replace("http://", "https://") != metadata_dtd_uri:
> +            if doctype_system != metadata_dtd_uri:
>                   if doctype_system is None:
>                       system_problem = "but it is undefined"
>                   else:


Looks good. Please merge.

-- 

Thanks,

Zac