Re: [gentoo-portage-dev] Re: [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions.

[Zac Medico]

On 10/27/2014 06:15 AM, Michael Palimaka wrote:
> On 27/10/14 07:05, Zac Medico wrote:
>> On 10/26/2014 12:31 PM, Michael Palimaka wrote:
>>> I've sent updated patches based on the last feedback. Should I send a
>>> new one with the aliases, and if so, should the portage checks use the
>>> alias or real function?
>>
>> Considering Micha³'s plan to expose these functions to QA checks in
>> repositories, it would make sense to go ahead and add expose the aliases
>> in misc-functions.sh now. On the other hand, it makes sense to use the
>> prefixed versions in all internal portage code, for consistency. So, I'd
>> probably just wait until later to add the unprefixed versions. I don't
>> have a strong opinion though. The new patch set that you posted looks
>> good to me.
>
> That's fine, we can just add the alias when Micha³'s GLEP is finalised then.

I've pushed your patches:

https://github.com/gentoo/portage/commit/ab43c1944f0cb6bf43d5b40cceb2e8186645d347
https://github.com/gentoo/portage/commit/5c54f2b18112b779d5dcba30837b34aac74739e9
https://github.com/gentoo/portage/commit/01e148aac631a0d1c78968dea96ebd9ed94e5918

In the first patch, I wrapped lines inside __eqalog.

In the last patch, I did some trivial fixups for quoting and globbing:

diff --git a/bin/install-qa-check.d/90world-writable b/bin/install-qa-check.d/90world-writable
index 4d5f4ab..490aaee 100644
--- a/bin/install-qa-check.d/90world-writable
+++ b/bin/install-qa-check.d/90world-writable
@@ -3,16 +3,17 @@
 world_writable_check() {
 	# Now we look for all world writable files.
 	local unsafe_files=$(find "${ED}" -type f -perm -2 | sed -e "s:^${ED}:/:")
-	local OLDIFS x
+	local OLDIFS x prev_shopts=$-
 
 	OLDIFS=$IFS
 	IFS=$'\n'
+	set -f
 
 	if [[ -n ${unsafe_files} ]] ; then
 		eqawarn "QA Security Notice: world writable file(s):"
 
 		for x in $unsafe_files ; do
-			__eqawarnlog world-writable $x
+			__eqawarnlog world-writable "$x"
 		done
 
 		eqawarn "This may or may not be a security problem, most of the time it is one."
@@ -25,12 +26,13 @@ world_writable_check() {
 		eqawarn "QA Notice: Unsafe files detected (set*id and world writable)"
 
 		for x in $unsafe_files ; do
-			__eqawarnlog world-writable-setid $x
+			__eqawarnlog world-writable-setid "$x"
 		done
 		die "Unsafe files found in \${D}.  Portage will not install them."
 	fi
 
 	IFS=OLDIFS
+	[[ ${prev_shopts} == *f* ]] || set +f
 }
 
 world_writable_check

-- 
Thanks,
Zac