Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] Check for and report read-only filesystems
Date: Sat, 11 Jan 2014 05:13:06
Message-Id: 1389416943.7103.136.camel@big_daddy.dol-sen.ca
In Reply to: [gentoo-portage-dev] [PATCH] Check for and report read-only filesystems by Chris Reffett
1 On Fri, 2014-01-10 at 22:07 -0500, Chris Reffett wrote:
2 > Hi all,
3 > Attached is a patch to test if Portage is going to write to a
4 > read-only filesystem and print out the list of filesystems that need
5 > to be remounted RW. This leaves ${D} intact rather than having some
6 > files moved before hitting the RO filesystem. Fixes bug 378869. Since
7 > git.overlays.gentoo.org is down, I haven't had the chance to rebase
8 > this against latest, but I can resubmit if it doesn't cleanly apply.
9 > This is my first patch to the list, so I apologize if I didn't submit
10 > correctly.
11 >
12 > Chris Reffett
13
14
15 yeah, patch looks good.
16
17 Only thing I didn't like is the return 1 IS that suppose to be True or
18 sys.exit() value?
19
20 If that is what the module was using, then it's ok. Personally I'm not
21 a fan of using 0, 1 for False, True.
22
23 But that will come later...

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies