Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] depgraph: Skip atoms that are None (bug 505944)
Date: Fri, 28 Mar 2014 09:07:57
Message-Id: 53353BE5.4080804@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] depgraph: Skip atoms that are None (bug 505944) by Brian Dolbec
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 27/03/14 17:16, Brian Dolbec wrote:
5 > diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
6 > index 83035c2..61ef31d 100644 --- a/pym/_emerge/depgraph.py +++
7 > b/pym/_emerge/depgraph.py @@ -1942,8 +1942,9 @@ class
8 > depgraph(object): # Display the specific atom from SetArg or #
9 > Package types. uneval = "" - if
10 > dep.atom is not dep.atom.unevaluated_atom: -
11 > uneval = " (%s)" % (dep.atom.unevaluated_atom,) +
12 > if dep.atom and dep.atom.unevaluated_atom: +
13 > if dep.atom is not dep.atom.unevaluated_atom: +
14 > uneval = " (%s)" % (dep.atom.unevaluated_atom,) writemsg_level(
15 > "%s%s%s required by %s\n" % ("Parent Dep:".ljust(15), dep.atom,
16 > uneval, myparent), lines 1-16/16 (END)
17 >
18 >
19 > This takes advantage of the fact that uneval is initialized to ""
20 > Then only reassigns it if there is actually a mismatch.
21 Sure. I'd use one "if" instead of two.
22 - --
23 Alexander
24 bernalex@g.o
25 https://secure.plaimi.net/~alexander
26 -----BEGIN PGP SIGNATURE-----
27 Version: GnuPG v2.0.22 (GNU/Linux)
28 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
29
30 iF4EAREIAAYFAlM1O+UACgkQRtClrXBQc7XL+AD/Wn5sbE/O3QFAl7nBYblVWFAK
31 LBVwmY3XEOT2blgIPfIA/2a8IspgldZxO2AmLQ/bZNnFcigUPejaZ1V8J97JJuiu
32 =qc0Y
33 -----END PGP SIGNATURE-----