Gentoo Archives: gentoo-portage-dev

From: Tom Wijsman <tomwij@g.o>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] [PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084).
Date: Thu, 16 Jan 2014 00:08:54
Message-Id: 1389830840-25848-4-git-send-email-tomwij@gentoo.org
In Reply to: [gentoo-portage-dev] Repoman patches for bugs #205909, #245305 and #482084. by Tom Wijsman
1 ---
2 bin/repoman | 2 ++
3 man/repoman.1 | 3 +++
4 pym/repoman/checks.py | 10 ++++++++++
5 3 files changed, 15 insertions(+)
6
7 diff --git a/bin/repoman b/bin/repoman
8 index 3263ceb..6754edd 100755
9 --- a/bin/repoman
10 +++ b/bin/repoman
11 @@ -318,6 +318,7 @@ qahelp = {
12 "EAPI.incompatible": "Ebuilds that use features that are only available with a different EAPI",
13 "EAPI.unsupported": "Ebuilds that have an unsupported EAPI version (you must upgrade portage)",
14 "SLOT.invalid": "Ebuilds that have a missing or invalid SLOT variable value",
15 + "G2CONF.deprecated": "G2CONF is deprecated, see Gentoo bug #482084 and the GNOME team policies",
16 "HOMEPAGE.missing": "Ebuilds that have a missing or empty HOMEPAGE variable",
17 "HOMEPAGE.virtual": "Virtuals that have a non-empty HOMEPAGE variable",
18 "PDEPEND.suspect": "PDEPEND contains a package that usually only belongs in DEPEND.",
19 @@ -382,6 +383,7 @@ qawarnings = set((
20 "dependency.badtilde",
21 "DESCRIPTION.toolong",
22 "EAPI.deprecated",
23 +"G2CONF.deprecated",
24 "HOMEPAGE.virtual",
25 "LICENSE.deprecated",
26 "LICENSE.virtual",
27 diff --git a/man/repoman.1 b/man/repoman.1
28 index 2bf3765..7ec43d5 100644
29 --- a/man/repoman.1
30 +++ b/man/repoman.1
31 @@ -227,6 +227,9 @@ Syntax error in RESTRICT (usually an extra/missing space/parenthesis)
32 .B SLOT.invalid
33 Ebuilds that have a missing or invalid SLOT variable value
34 .TP
35 +.B G2CONF.deprecated
36 +G2CONF is deprecated, see Gentoo bug #482084 and the GNOME team policies
37 +.TP
38 .B SRC_URI.mirror
39 A uri listed in profiles/thirdpartymirrors is found in SRC_URI
40 .TP
41 diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
42 index 85aa065..c2608b0 100644
43 --- a/pym/repoman/checks.py
44 +++ b/pym/repoman/checks.py
45 @@ -799,6 +799,16 @@ class PortageInternalVariableAssignment(LineCheck):
46 e += ' on line: %d'
47 return e
48
49 +class DeprecateG2CONF(LineCheck):
50 + repoman_check_name = 'G2CONF.deprecated'
51 + re = re.compile(r'.*G2CONF.*')
52 +
53 + def check(self, num, line):
54 + """Run the check on line and return error if there is one"""
55 + m = self.re.match(line)
56 + if m is not None:
57 + return ("G2CONF on line %d is deprecated, see Gentoo bug #482084.")
58 +
59 _base_check_classes = (InheritEclass, LineCheck, PhaseCheck)
60 _constant_checks = None
61
62 --
63 1.8.5.2

Replies