Re: [gentoo-portage-dev] [PATCH] Colorize packages in user sets (bug 577720)

[Adam Mills]

Thanks for all the feedback so far. I probably should have just filed 
the bug
and left it at that, but I'm committed now.

I've done my best to incorporate all of the suggestions here, and 
submitted a
new patch rev 3. I have a few questions about details I'm pretty sure 
still
need improvement:

1) In order to build the InternalPackageSet only once, I used the
   _DisplayConfig target_root, instead of using pkg.root in the 
check_sets
   method. I'm not sure of the pkg.root purpose, but if there can be 
different
   roots, the InternalPackageSet would have to be created for each 
package.
   If that's the case, it could be moved to the check_sets method, and 
created
   for each package.

2) I added the new InternalPackageSet as a new member of the 
_DisplayConfig
   class. Let me know if there's somewhere more appropriate, especially 
after
   the feedback from #1.

3) Is there a better method available for merging PackageSets?

Thanks,
Adam