| 1 |
On 01/25/2018 10:42 PM, Michał Górny wrote: |
| 2 |
> W dniu czw, 25.01.2018 o godzinie 21∶30 -0800, użytkownik Zac Medico |
| 3 |
> napisał: |
| 4 |
>> On 01/25/2018 01:11 AM, Michał Górny wrote: |
| 5 |
>>> W dniu czw, 25.01.2018 o godzinie 10∶07 +0100, użytkownik Michael |
| 6 |
>>> Haubenwallner napisał: |
| 7 |
>>>> Hi, |
| 8 |
>>>> |
| 9 |
>>>> ${Subject} ringing a bell here: |
| 10 |
>>>> |
| 11 |
>>>> dev-db/oracle-instantclient is fetch restricted. As a binary package with |
| 12 |
>>>> multiple USE options there's a bunch of files to download - even for |
| 13 |
>>>> multiple archs when multilib is active. |
| 14 |
>>>> |
| 15 |
>>>> So in pkg_nofetch() I'm telling the user whether a file to download is |
| 16 |
>>>> "already here" or "still absent", by testing if $A exists in $DISTDIR. |
| 17 |
>>>> |
| 18 |
>>>> With ${Subject}, I'm wondering if DISTDIR is created for pkg_nofetch too. |
| 19 |
>>>> |
| 20 |
>>> |
| 21 |
>>> You're doing the wrong thing then. DISTDIR is not allowed |
| 22 |
>>> in pkg_nofetch(). |
| 23 |
>> |
| 24 |
>> It seems to be a common assumption that it's allowed, this command |
| 25 |
>> currently shows 163 results in the gentoo repo: |
| 26 |
>> |
| 27 |
>> git grep -l pkg_nofetch | xargs grep 'e\(log\|info\).*DISTDIR' | wc -l |
| 28 |
>> |
| 29 |
>> We should double check with the PMS maintainers to see if they think |
| 30 |
>> it's worthy of an exception. Otherwise, we need to announce the issue on |
| 31 |
>> the gentoo-dev mailing list. |
| 32 |
> |
| 33 |
> PMS maintainers already verified that back during the first run of those |
| 34 |
> patches. However, we believe the only reasonable way to get this out of |
| 35 |
> pkg_nofetch() is to actually stop it from working, so people would stop |
| 36 |
> using it. |
| 37 |
|
| 38 |
Okay, that works for me. The patches looks good. Please merge. |
| 39 |
-- |
| 40 |
Thanks, |
| 41 |
Zac |
Archives