| 1 |
On 11/30/2014 12:25 PM, Micha³ Górny wrote: |
| 2 |
> Dnia 2014-11-30, o godz. 11:26:16 |
| 3 |
> Zac Medico <zmedico@g.o> napisa³(a): |
| 4 |
> |
| 5 |
>> On 11/30/2014 09:36 AM, Micha³ Górny wrote: |
| 6 |
>>> @@ -628,7 +665,11 @@ einstall() { |
| 7 |
>>> sysconfdir="${ED}etc" \ |
| 8 |
>>> ${LOCAL_EXTRA_EINSTALL} \ |
| 9 |
>>> ${MAKEOPTS} -j1 \ |
| 10 |
>>> - "$@" ${EXTRA_EMAKE} install || die "einstall failed" |
| 11 |
>>> + "$@" ${EXTRA_EMAKE} install |
| 12 |
>>> + then |
| 13 |
>>> + __helpers_die "einstall failed" |
| 14 |
>>> + return 1 |
| 15 |
>>> + fi |
| 16 |
>>> else |
| 17 |
>>> die "no Makefile found" |
| 18 |
>>> fi |
| 19 |
>>> |
| 20 |
>> |
| 21 |
>> The patch all looks good to me. However, the last die shown in the diff |
| 22 |
>> context here makes me wonder why that one wasn't converted from die to |
| 23 |
>> __helpers_die. |
| 24 |
> |
| 25 |
> Because it's incorrect use, not a call failure :). I have decided to |
| 26 |
> use __helpers_die whenever the executed command fails but force die |
| 27 |
> on asserts and invalid uses. |
| 28 |
|
| 29 |
Okay, sounds pretty reasonable to me. |
| 30 |
-- |
| 31 |
Thanks, |
| 32 |
Zac |
Archives