From: | Mark Kubacki <wmark@×××××××××.de> | ||
---|---|---|---|
To: | gentoo-portage-dev@l.g.o | ||
Subject: | Re: [gentoo-portage-dev] [PATCH] portage: HTTP if-modified-since and compression | ||
Date: | Thu, 02 Aug 2012 21:09:22 | ||
Message-Id: | CAHw5crL8BAtTJ1-cy2NMLJf8Un8tQ0+Ko-zeK0XC1bBOVJxpFg@mail.gmail.com | ||
In Reply to: | Re: [gentoo-portage-dev] [PATCH] portage: HTTP if-modified-since and compression by Zac Medico |
1 | 2012/8/2 Zac Medico <zmedico@g.o>: |
2 | > On 08/01/2012 06:02 PM, Zac Medico wrote: |
3 | >> |
4 | >> Thanks, I've applied your patches: |
5 | >> |
6 | >> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=e06cb6d66db37ac7ab77acf65038b1f770c13c96 |
7 | >> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=cbebf76d8e5666aad4984f87c2be83d474fe5a7e |
8 | >> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=13abe0398fbe724218c8c9ac2597ebe15d7db7e1 |
9 | >> |
10 | >> I made a few trivial change in order to make them compatible with |
11 | >> python3. Also, I made it use the old behavior for protocols other than |
12 | >> http and https, in order to avoid issues with ftp like this one: |
13 | >> |
14 | >> https://bugs.gentoo.org/show_bug.cgi?id=415579 |
15 | >> |
16 | > |
17 | > Fix python2 http password breakage: |
18 | > |
19 | > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=fbeb8101b20e232b2e8c55c9554b5fc9c5c72089 |
20 | > |
21 | > BUG: The if_modified_since parameter appears to be ignored when using |
22 | > http password authentication. |
23 | |
24 | Hi Zac, |
25 | |
26 | In one word: Great! I love your modifications. Thank you! |
27 | |
28 | Regarding functionality – there is still some room for more |
29 | optimizations and more features. For example, if the local copy is no |
30 | older than x seconds then there's no need to contact any remote |
31 | server. Expect patches. |
32 | |
33 | As for the bug. As long as the "If-Modified-Since" header is sent |
34 | Portage has done its job. Some servers use the header as "ETag" |
35 | replacement and don't do the more costly greater-than comparison (see |
36 | also [1]; TIMESTAMP_TOLERANCE should be a configuration option so |
37 | users can set it to 0 now that the "mtime"-patch has been accepted). |
38 | And, BaseHandler are chained automatically by "build_opener". |
39 | Nevertheless, I will look into the whole issue the next days. |
40 | |
41 | -- |
42 | Grüße, Mark |
Subject | Author |
---|---|
Re: [gentoo-portage-dev] [PATCH] portage: HTTP if-modified-since and compression | Zac Medico <zmedico@g.o> |
Re: [gentoo-portage-dev] [PATCH] portage: HTTP if-modified-since and compression | Brian Dolbec <dolsen@g.o> |