Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 3/3] CONFIG_PROTECT: protect symlinks, bug #485598
Date: Mon, 27 Oct 2014 08:08:08
Message-Id: 544DFD61.3010804@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 3/3] CONFIG_PROTECT: protect symlinks, bug #485598 by zmedico@gentoo.org
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 I'm not sure how anyone is seriously supposed to do an in-depth review
5 of 500+ changes. For what it's worth, what I could stomach reading of
6 the vartree changes, looked relatively sane. The commit messages also
7 seem to indicate you're doing something sane.
8
9 Is there no way of splitting these things into smaller commits that
10 make sense? As they are right now, it's almost pointless to even look
11 at the diff. One would have to look at the old and new source in their
12 entireties next to each other to get the bigger picture. (I might find
13 time for this later this week.)
14 - --
15 Alexander
16 bernalex@g.o
17 https://secure.plaimi.net/~alexander
18 -----BEGIN PGP SIGNATURE-----
19 Version: GnuPG v2
20 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
21
22 iF4EAREIAAYFAlRN/WEACgkQRtClrXBQc7VEhwD9Gwa24KWNL47fjpcs375y7UEX
23 aAtuebxbhZSm/fq5xpAA/jDfmH+/rmJGARDr4ds8UyVtCkKfvTnD1ClGa9biRuI5
24 =8rjH
25 -----END PGP SIGNATURE-----

Replies