Re: [gentoo-portage-dev] [PATCH] depgraph: clarify "update has been skipped" message (bug 602854)

[Brian Dolbec]

On Wed, 28 Dec 2016 16:01:04 -0800
Zac Medico <zmedico@g.o> wrote:

> When an update has been skipped, clearly display both the selected and
> skipped packages.
>
> X-Gentoo-bug: 602854
> X-Gentoo-bug-url: https://bugs.gentoo.org/602854
> ---
>  pym/_emerge/depgraph.py | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
> index cb12b05..e298337 100644
> --- a/pym/_emerge/depgraph.py
> +++ b/pym/_emerge/depgraph.py
> @@ -1044,7 +1044,14 @@ class depgraph(object):
>  			writemsg(str(pkg.slot_atom), noiselevel=-1)
>  			if pkg.root_config.settings["ROOT"] != "/":
>  				writemsg(" for %s" % (pkg.root,),
> noiselevel=-1)
> -			writemsg("\n", noiselevel=-1)
> +			writemsg("\n\n", noiselevel=-1)
> +
> +			selected_pkg =
> next(self._dynamic_config._package_tracker.match(
> +				pkg.root, pkg.slot_atom), None)
> +
> +			writemsg("  selected: %s\n" %
> (selected_pkg,), noiselevel=-1)
> +			writemsg("  skipped: %s (see unsatisfied
> dependency below)\n"
> +				% (pkg,), noiselevel=-1)
>
>  			for parent, root, atom in parent_atoms:
>  				self._show_unsatisfied_dep(root,
> atom, myparent=parent)


looks good :)
-- 
Brian Dolbec <dolsen>