Re: [gentoo-portage-dev] [PATCH] filter-bash-environment.py: use buffered input, raw bytes (bug 647654)

[Zac Medico]

On 02/14/2018 12:46 PM, Alec Warner wrote:
> On Wed, Feb 14, 2018 at 3:38 PM, Zac Medico <zmedico@g.o
> <mailto:zmedico@g.o>> wrote:
>
>     Use sys.stdin.buffer instead of sys.stdin.buffer.raw, for buffered
>     input.
>     Also use raw bytes instead of unicode strings, in order to avoid making
>     assumptions about character encodings, and also to avoid overhead from
>     unicode decoding/encoding.
>
>
> Maybe a functional test?

In PATCH v2 I've added a unit test that compares expected output to
actual output.

> take real environment, check it into source code, run filter over it to
> get output, run bash -n on output?
>
> Better ideas?

We already have a number of tests that do the equivalent with a complete
ebuild.sh by calling emerge. The resulting environment is sourced, and
that will fail if the bash syntax is invalid. All of those tests failed
for python3.4 here because it doesn't support the % operator with bytes
operands:

https://travis-ci.org/gentoo/portage/jobs/341614451
-- 
Thanks,
Zac