Archives
Archives
| From: | Zac Medico <zmedico@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o, Alec Warner <antarus@g.o> | ||
| Cc: | Zac Medico <zmedico@g.o> | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: install new package, allow upgrade (bug 643974) | ||
| Date: | Wed, 10 Jan 2018 20:23:22 | ||
| Message-Id: | bb5b8514-4db7-aa26-d55f-fe4d4c48c11d@gentoo.org | ||
| In Reply to: | Re: [gentoo-portage-dev] [PATCH] dep_zapdeps: install new package, allow upgrade (bug 643974) by Alec Warner |
||
| 1 | On 01/10/2018 09:00 AM, Alec Warner wrote: |
| 2 | > The code lgtm. |
| 3 | |
| 4 | Thanks! |
| 5 | |
| 6 | > Slightly unsure if we need an entirely new test, as opposed to just |
| 7 | > generalizing the test cases (like you did the code). But either way is |
| 8 | > probably fine. |
| 9 | |
| 10 | Well, it seems like the only benefit of combining the tests together |
| 11 | would be to share the 'ebuilds' variable. All of the same cases that |
| 12 | I've covered would still need to be covered separately. |
| 13 | -- |
| 14 | Thanks, |
| 15 | Zac |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |