| 1 |
On 17-08-2009 23:06:01 -0700, Zac Medico wrote: |
| 2 |
> Zac Medico wrote: |
| 3 |
> > Fabian Groffen wrote: |
| 4 |
> >> The attached patch makes all variables against config_root relative (by |
| 5 |
> >> removing the leading '/'), with the result that all lstrip(os.sep) calls |
| 6 |
> >> in the code can be removed. Please note that all but two occurences did |
| 7 |
> >> use config_root. For one (pym/portage/__init__.py; sandbox stuff) I've |
| 8 |
> >> added it, for the other (in pym/portage/output.py) I don't know how to |
| 9 |
> >> get config_root, so substituted '/', which breaks Prefix by design. |
| 10 |
> > |
| 11 |
> > Your patch is in svn r13821. |
| 12 |
> > |
| 13 |
> > I've added a comment in output.py that we can use ObjectProxy to |
| 14 |
> > implement lazy initialization of codes and _styles, and add an |
| 15 |
> > init(config_root="/") function that can be called in order adjust |
| 16 |
> > the location that color.map is read from. |
| 17 |
> |
| 18 |
> I've added an _init(config_root="/") function like this in r14083. |
| 19 |
|
| 20 |
thanks, I've removed the FIXME comment in trunk, since it's fixed now |
| 21 |
|
| 22 |
|
| 23 |
-- |
| 24 |
Fabian Groffen |
| 25 |
Gentoo on a different level |
Archives