Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Zac Medico <zmedico@g.o>
Subject: [gentoo-portage-dev] [PATCH] emerge: warn about @installed, don't deprecate (387059)
Date: Fri, 28 Nov 2014 22:29:21
Message-Id: 1417213746-12383-1-git-send-email-zmedico@gentoo.org
1 The @installed set may have some legitimate uses. Therefore, change
2 the deprecation warning to a warning about unsolved blockers. The
3 warning will now appear as follows:
4
5 * The @installed set is not recommended when updating
6 * packages because it will often introduce unsolved blocker
7 * conflicts. Please refer to bug #387059 for details.
8
9 X-Gentoo-Bug: 387059
10 X-Gentoo-Url: https://bugs.gentoo.org/show_bug.cgi?id=387059
11 ---
12 pym/_emerge/actions.py | 8 +++++---
13 1 file changed, 5 insertions(+), 3 deletions(-)
14
15 diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py
16 index dec5b04..d9c45c1 100644
17 --- a/pym/_emerge/actions.py
18 +++ b/pym/_emerge/actions.py
19 @@ -3538,10 +3538,12 @@ def expand_set_arguments(myfiles, myaction, root_config):
20 display_missing_pkg_set(root_config, s)
21 return (None, 1)
22 if s == "installed":
23 - msg = ("The @installed set is deprecated and will soon be "
24 - "removed. Please refer to bug #387059 for details.")
25 + msg = ("The @installed set is not recommended when "
26 + "updating packages because it will often "
27 + "introduce unsolved blocker conflicts. Please "
28 + "refer to bug #387059 for details.")
29 out = portage.output.EOutput()
30 - for line in textwrap.wrap(msg, 50):
31 + for line in textwrap.wrap(msg, 57):
32 out.ewarn(line)
33 setconfig.active.append(s)
34
35 --
36 2.0.4