Gentoo Archives: gentoo-portage-dev

From: Alec Warner <antarus@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Michael Orlitzky <mjo@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH] emerge: add --changed-deps-report option (bug 645780)
Date: Mon, 29 Jan 2018 04:34:06
Message-Id: CAAr7Pr8mKLMBEnHG5dEpWEL_5+JJ_xv-UrMzkjs5abEpvB61eQ@mail.gmail.com
In Reply to: Re: [gentoo-portage-dev] [PATCH] emerge: add --changed-deps-report option (bug 645780) by Zac Medico
1 On Sun, Jan 28, 2018 at 8:10 PM, Zac Medico <zmedico@g.o> wrote:
2
3 > On 01/28/2018 04:17 PM, Michael Orlitzky wrote:
4 > > Since ::gentoo is the only repository governed by the PMS, can't we make
5 > > repoman do this? The problem with requiring "repoman --force" for an
6 > > in-place dependency change is that repoman generally won't have access
7 > > to the unedited ebuild; but for ::gentoo, we can probably hack something
8 > > together in git. Have it source the old and new ebuilds, and compare
9 > > their dependency lists.
10 >
11 > Yes I'm in favor of that, but it doesn't accomplish my current goal, as
12 > I'll explain below.
13 >
14 > > It won't work outside of a git repo, but it will work in the one place
15 > > that really matters.
16 >
17 > My goal for this patch is to provide a safety net for users, such that
18 > they'll be automatically notified that the --changed-deps option is
19 > available when needed to solve problems involving stale dependencies.
20 > The reason behind this goal is that git commits flow directly to rsync
21 > without any restriction, which makes users vulnerable to stale
22 > dependencies, in the form of failed dependency calculations.
23 >
24
25 What I would go along with is:
26
27 1) If we can determine the depgraph failed and
28 2) We can determine that dependencies changed.
29 3) Show a NOTE telling users about --changed-deps=y
30
31 But I'm not sure the patch does this today? I think it will trigger too
32 aggressively. But ultimately I'm not against helping users work around this
33 sort of breakage.
34
35
36 > This goal is currently my highest priority, since I want to protect
37 > users from having difficulty with problems triggered by the new
38 > --dynamic-deps=n default [1].
39 >
40 > [1] https://bugs.gentoo.org/645550
41 > --
42 > Thanks,
43 > Zac
44 >
45 >

Replies