Gentoo Archives: gentoo-portage-dev

From: Brian Harring <ferringb@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] Re: [gentoo-dev-portage] [PATCH] prevent world file corruption by writing atomically
Date: Sun, 05 Feb 2006 12:15:48
Message-Id: 20060205121403.GC29404@nightcrawler.had1.or.comcast.net
In Reply to: [gentoo-portage-dev] Re: [gentoo-dev-portage] [PATCH] prevent world file corruption by writing atomically by Zac Medico
1 On Mon, Jan 30, 2006 at 10:21:22AM -0800, Zac Medico wrote:
2 > Zac Medico wrote:
3 > > Okay, I've created a file-like class called atomic_ostream and it is now used for both write_atomic() and writedict().
4 >
5 > I've been using this patch locally with no problems. Do we have
6 > any more feedback or are people satisfied with it? IMO we need
7 > something like this, if not for (unsupported) parallel merges, at
8 > least to prevent loss of an important file when it is being
9 > overwritten and an IO error occurs (see bug 114133).
10
11 Meh.... you're not supposed to call me on being a slacker for not
12 commenting. :)
13
14 No complaints with this going into svn for upcoming 2.1_pre*, but I'd
15 like to see the class rewritten actually- the file object lacks a lot
16 of capabilities that a normal file object has.
17
18 I'd suggest deriving straight from the file class, and just doing
19 changes in close and open. Should be a much smaller class also ;)
20
21 ~harring

Replies