Gentoo Archives: gentoo-portage-dev

From: Alec Warner <antarus@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] qfile assumes category names contain a hyphen
Date: Mon, 16 Mar 2009 17:49:14
Message-Id: b41005390903161049k42d7aec6w6d5a6abddb716e96@mail.gmail.com
In Reply to: [gentoo-portage-dev] qfile assumes category names contain a hyphen by Amit Dor-Shifer
1 On Mon, Mar 16, 2009 at 9:34 AM, Amit Dor-Shifer <amitds@××××××.com> wrote:
2 > Hi all.
3 >
4 > While working on my overlay, I stumbled on an issue where qfile refused to
5 > acknowledge an installed file as being part of my package.
6 >
7 > Looking into q's implementation (portage-utils-0.1.29), I see:
8 >
9 > amit0 portage-utils-0.1.29 # grep -A 2 next_entry ./libq/vdb_get_next_dir.c
10 > next_entry:
11 > ret = readdir(dir);
12 > if (ret == NULL) {
13 > --
14 > goto next_entry;
15 > if (strchr(ret->d_name, '-') == NULL)
16 > if ((strcmp(ret->d_name, "virtual")) != 0)
17 > goto next_entry;
18 >
19 > I encountered this since I used a new category, which only contained a
20 > single word. Adding a hyphen and a 2nd token solved my issue, and now qfile
21 > knows the file's association.
22 >
23 > Is this assumption, that category should be "stringA-stringB" documented
24 > somewhere?
25
26 It is a legacy assumption that we had prior to the introduction of the
27 'virtual' category into gentoo-x86.
28
29 >
30 > 10x,
31 > Amit
32 >
33 >
34 >
35 >