| 1 |
>>>>> On Thu, 25 Jan 2018, Zac Medico wrote: |
| 2 |
|
| 3 |
> It seems to be a common assumption that it's allowed, this command |
| 4 |
> currently shows 163 results in the gentoo repo: |
| 5 |
|
| 6 |
> git grep -l pkg_nofetch | xargs grep 'e\(log\|info\).*DISTDIR' | wc -l |
| 7 |
|
| 8 |
There will be little breakage if it is only used in elog messages. |
| 9 |
|
| 10 |
> We should double check with the PMS maintainers to see if they think |
| 11 |
> it's worthy of an exception. Otherwise, we need to announce the |
| 12 |
> issue on the gentoo-dev mailing list. |
| 13 |
|
| 14 |
PMS had never defined DISTDIR in pkg_* phases. You can see this e.g. |
| 15 |
in the PMS version from 2010 [1]. |
| 16 |
|
| 17 |
In addition to this, the following clarification of variables' scope |
| 18 |
was approved by the council in 2017 [2]: |
| 19 |
|
| 20 |
| 6. Scope and consistency of FILESDIR and DISTDIR |
| 21 |
| ------------------------------------------------ |
| 22 |
| Old: src_* (not consistent across ebuild phases) |
| 23 |
| New: src_*, global scope (consistent). No access to the dir in |
| 24 |
| global scope. |
| 25 |
| |
| 26 |
| Rationale: These variables must be defined in global scope for |
| 27 |
| assignment of the PATCHES variable in EAPI 6. However, the actual |
| 28 |
| directories are not necessarily present in global scope (e.g., when |
| 29 |
| installing from a binary package) and therefore must not be accessed |
| 30 |
| there. |
| 31 |
|
| 32 |
Ulrich |
| 33 |
|
| 34 |
|
| 35 |
[1] https://projects.gentoo.org/pms/3/pms.html#x1-117002 |
| 36 |
[2] https://bugs.gentoo.org/616206 |
Archives