Gentoo Archives: gentoo-portage-dev

From: "Michael A. Smith" <michael@××××××××.com>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] Re: equery refactorization
Date: Sun, 07 Dec 2008 03:02:08
Message-Id: 493B3CAD.9070304@smith-li.com
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 Regarding gentoolkit/trunk/src/equery/tests
5
6 I discovered all the test kit that's in equery, and have been refactoring 'em.
7 They're written in bash, not python, so they're a candidate for some kind of
8 python unit testing. Right now, however, that's not a priority for me, so I'm
9 just making the bash cleaner and hopefully faster and more maintainable. I
10 think it'll be helpful as we refactor.
11
12 The question is, how maintainable are the "help" tests? These are tests that
13 try to confirm that the --help output of each module is correct. I think it
14 might be more work than it's worth to try to maintain those...
15
16 Thoughts?
17
18 - -Michael
19
20 Douglas Anderson wrote:
21 | Hi, I'm interesting in tinkering with equery and doing some
22 | refactorization in my spare time. I wrote a script that some people
23 | mentioned would be a good module for equery (emeta, it's on bugzilla),
24 | but as I was looking into that, I noticed that equery is written as a
25 | script, even though it would probably really benifit from being modularized.
26 |
27 | Again, this is just because I have some free time right now and a
28 | willingness to learn about Portage, but I thought I'd check with you
29 | guys first. If I'm willing to do it without bother you all too much,
30 | would it be something you're interested in me doing? My idea is to set
31 | it up more like a Python package than a script, like:
32 | /usr/lib/gentoolkit/pym/gentoolkit/equery/
33 | /usr/lib/gentoolkit/pym/gentoolkit/equery/__init__.py
34 | /usr/lib/gentoolkit/pym/gentoolkit/equery/belongs.py
35 | /usr/lib/gentoolkit/pym/gentoolkit/equery/check.py
36 | /usr/lib/gentoolkit/pym/gentoolkit/equery/depends.py
37 | etc...
38 |
39 | I think it would increase startup time and make adding or upgraded
40 | modules easier in the future.
41 |
42 | Well, I have a few more questions but I'll wait and see if this would be
43 | a positive thing or not.
44 |
45 | Thanks for your time,
46 | -Doug
47
48 -----BEGIN PGP SIGNATURE-----
49 Version: GnuPG v2.0.9 (GNU/Linux)
50 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
51
52 iEYEARECAAYFAkk7PKwACgkQzwtr5yY0JZxRfwCglG3TzY3iQR5UzpmovYxRa6ME
53 YI0An13fhKAxcd0Vr7pQ8uY80SyDKLAU
54 =BCpZ
55 -----END PGP SIGNATURE-----

Replies

Subject Author
Re: [gentoo-portage-dev] Re: equery refactorization Douglas Anderson <dja@××××××.com>