From: | Zac Medico <zmedico@g.o> | ||
---|---|---|---|
To: | gentoo-portage-dev@l.g.o | ||
Subject: | Re: [gentoo-portage-dev] [PATCH] egencache: Migrate _special_filename class to portage.utils.changelog for api use | ||
Date: | Sat, 03 Dec 2016 22:10:43 | ||
Message-Id: | c8a5e406-f88e-945a-caef-e25a811ab25b@gentoo.org | ||
In Reply to: | [gentoo-portage-dev] [PATCH] egencache: Migrate _special_filename class to portage.utils.changelog for api use by Brian Dolbec |
1 | On 12/03/2016 01:49 PM, Brian Dolbec wrote: |
2 | > + if self.file_type_lt(self, other): |
3 | > + return True |
4 | > + elif self.file_type_lt(other, self): |
5 | > + return False |
6 | |
7 | Patch looks good, except there are 2 missed renames from file_type_lt to |
8 | _file_type_lt above. |
9 | -- |
10 | Thanks, |
11 | Zac |
Subject | Author |
---|---|
Re: [gentoo-portage-dev] [PATCH] egencache: Migrate _special_filename class to portage.utils.changelog for api use | Brian Dolbec <dolsen@g.o> |