Re: [gentoo-portage-dev] [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions.

[Zac Medico]

On 10/25/2014 09:15 AM, Michael Palimaka wrote:
> +eqalog() {
> +	local tag=$1 x
> +	shift
> +	for x in "$@" ; do
> +		echo "${tag}" "${x}" >> "${T}"/qa.log
> +	done
> +}

Your patches look good to me, except that I think eqalog should escape
any \n characters that might be embedded in the arguments.

We might use something like this to escape all but the last \n character:

echo "${tag}" "${x}"| (escape="" ; while read -r ; do echo -n "${escape}${REPLY}" ; escape="\\n"; done ; echo ) >> "${T}"/qa.log

Here's a test case showing that it works:

$ echo -e "foo\nbar\nbaz"| (escape="" ; while read -r ; do echo -n "${escape}${REPLY}" ; escape="\\n"; done ; echo )
foo\nbar\nbaz
-- 
Thanks,
Zac