Re: [gentoo-portage-dev] [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions.

[Zac Medico]

On 10/25/2014 01:26 PM, Micha³ Górny wrote:
> Dnia 2014-10-25, o godz. 12:53:15
> Zac Medico <zmedico@g.o> napisa³(a):
>
>> On 10/25/2014 09:15 AM, Michael Palimaka wrote:
>>> +eqalog() {
>>> +	local tag=$1 x
>>> +	shift
>>> +	for x in "$@" ; do
>>> +		echo "${tag}" "${x}" >> "${T}"/qa.log
>>> +	done
>>> +}
>>> +
>>> +eqawarnlog() {
>>> +	eqalog "$@"
>>> +	shift
>>> +	for x in "$@" ; do
>>> +		eqawarn "  $x"
>>> +	done
>>> +}
>>> +
>>
>> These functions are internals, so they need to be prefixed with __ like
>> __eqalog and __eqawarnlog.
>
> eqawarnlog shouldn't be internal since we support adding QA checks
> in repositories. In fact, I am planning to move some Gentoo-specific QA
> checks out of portage code.

It's a PMS thing. If it's not in PMS and the package manager provides
it, it's supposed to be prefixed.
-- 
Thanks,
Zac