Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-portage-dev
Navigation:
Lists: gentoo-portage-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-portage-dev@g.o
From: Mike Frysinger <vapier@g.o>
Subject: Re: [PATCH v2] repoman: add a mini framework for checking eclasses, and fill it out
Date: Wed, 30 May 2012 20:42:07 -0400
On Wednesday 30 May 2012 20:18:11 Zac Medico wrote:
> On 05/25/2012 09:20 AM, Mike Frysinger wrote:
> > On Thursday 24 May 2012 16:04:30 Zac Medico wrote:
> >> On 05/24/2012 12:20 PM, Mike Frysinger wrote:
> >>> Rather than copying & pasting the same behavior for the
> >>> different eclass checks, add a common class for them to extend.
> >>> This makes adding more eclass checks trivial, and keeps down
> >>> bitrot.
> >>> 
> >>> This does abuse the checking interface slightly -- the eclass
> >>> will change its category between unused and missing based on
> >>> the checks.
> >> 
> >> Looks good to me.
> > 
> > i'll push this now while we hammer out the "complete" solution
> > since these get pretty good coverage right now
> 
> Do you want to support EGIT_BOOTSTRAP settings prior to inherit?
> 
> For example, dev-libs/polylib/polylib-9999.ebuild triggers
> inherit.missing because InheritEclass currently expects the inherit to
> occur before the EGIT_BOOTSTRAP="eautoreconf" setting.

i don't think we need to support that level of detection.  it's a fairly 
extreme edge case, and we can just let the git eclass say "allow implicit 
autotools eclass inclusion" all the time.
-mike
Attachment:
signature.asc (This is a digitally signed message part.)
Replies:
Re: [PATCH v2] repoman: add a mini framework for checking eclasses, and fill it out
-- Zac Medico
References:
[PATCH] repoman: add a mini framework for checking eclasses, and fill it out
-- Mike Frysinger
Re: [PATCH v2] repoman: add a mini framework for checking eclasses, and fill it out
-- Mike Frysinger
Re: [PATCH v2] repoman: add a mini framework for checking eclasses, and fill it out
-- Zac Medico
Navigation:
Lists: gentoo-portage-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: [PATCH v2] repoman: add a mini framework for checking eclasses, and fill it out
Next by thread:
Re: [PATCH v2] repoman: add a mini framework for checking eclasses, and fill it out
Previous by date:
Re: [PATCH v2] repoman: add a mini framework for checking eclasses, and fill it out
Next by date:
Re: [PATCH v2] repoman: add a mini framework for checking eclasses, and fill it out


Updated Jun 13, 2012

Summary: Archive of the gentoo-portage-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.