1 |
-----BEGIN PGP SIGNED MESSAGE----- |
2 |
Hash: SHA512 |
3 |
|
4 |
On 06/03/2012 04:26 AM, Samuli Suominen wrote: |
5 |
> On 06/03/2012 06:20 AM, Samuli Suominen wrote: |
6 |
>> On 06/03/2012 03:01 AM, Ulrich Mueller wrote: |
7 |
>>>>>>>> On Sun, 03 Jun 2012, Samuli Suominen wrote: |
8 |
>>> |
9 |
>>>>> On 05/29/2012 10:09 AM, Fabian Groffen wrote: |
10 |
>>>> http://archives.gentoo.org/gentoo-dev/msg_920c6d6daafe7702bfa3b8a2bc21e0c1.xml |
11 |
>>>> |
12 |
>>>> |
13 |
>>> |
14 |
>>>>> |
15 |
>>>> |
16 |
Can you indicate what the council has to vote on/decide for this one? |
17 |
>>> |
18 |
>>>> EAPI=5 |
19 |
>>> |
20 |
>>>> optional: "$@" placement in default for src_configure() |
21 |
>>> |
22 |
>>>> econf "$@" |
23 |
>>> |
24 |
>>>> optional: "$@" placement in default for src_compile() |
25 |
>>> |
26 |
>>>> emake "$@" |
27 |
>>> |
28 |
>>> I still don't see the point of it. econf or emake could just be |
29 |
>>> called directly. We won't gain anything by allowing arguments, |
30 |
>>> but only complicate things. |
31 |
>>> |
32 |
>>>> this one is what I'm really after for: |
33 |
>>> |
34 |
>>>> default for src_install() in EAPI=5 should accept "$@" in |
35 |
>>>> correct place to avoid usage of EXTRA_EMAKE within |
36 |
>>>> ebuilds/eclasses and to avoid duplicating the Portage code |
37 |
>>>> for DOCS. NOTE: When this was last voted on for EAPI=3, we |
38 |
>>>> didn't have this DOCS handling, and this wasn't important |
39 |
>>>> yet. |
40 |
>>> |
41 |
>>>> emake DESTDIR="${D}" "$@" install |
42 |
>>> |
43 |
>>> Again, this could be called directly, which has the advantage |
44 |
>>> that it makes it obvious that src_install isn't the default. |
45 |
>> |
46 |
>> The difference is working the tree when you have to alter ebuilds |
47 |
>> which have been written like: |
48 |
>> |
49 |
>> DOCS=( AUTHORS README.NOW "${FILESDIR}"/README.Gentoo ) |
50 |
>> |
51 |
>> src_install() { default |
52 |
>> |
53 |
>> echo "Some command here." } |
54 |
>> |
55 |
>> At this point you have to move content of DOCS which may or may |
56 |
>> not rely on the ""quoting with array"". Remove the call to |
57 |
>> default. And then duplicate the EAPI=4 default into the ebuild. |
58 |
>> |
59 |
>> And then replicate that every month dozen times and keep on doing |
60 |
>> it for some months. Get frustrated. |
61 |
>> |
62 |
>> If that's not enough, then you get all excited about EAPI=4 and |
63 |
>> finally think you have a replacement for base.eclass to port |
64 |
>> xfconf.eclass away from the thing when you only used it for |
65 |
>> default src_install() to avoid code duplication... |
66 |
>> |
67 |
>> Think you are all done, and then get complainment that support |
68 |
>> for extra arguments for xfconf_src_install was killed, and was |
69 |
>> required for things like: |
70 |
>> |
71 |
>> xfconf_src_install htmldirectory=/usr/share/doc/${PF}/html |
72 |
>> imagesdir=/usr/share/doc/${PF}/html/images |
73 |
>> |
74 |
>> Where sedding the build system runs maintainer mode at .in level, |
75 |
>> and runnning autotools (.am level) requires heavy documentation |
76 |
>> dependencies. You go back to base.eclass and get frustrated |
77 |
>> more. |
78 |
>> |
79 |
>> I hope that clears things up ;-) |
80 |
>> |
81 |
> |
82 |
> Also, if not implemented, what is the replacement for EXTRA_EMAKE |
83 |
> which we are allowed to use from ebuilds? Or are we allowed to use |
84 |
> it? I think PMS didn't forbid it the last time I checked and it has |
85 |
> consumers in tree already. |
86 |
> |
87 |
> And if not implemented, would the council please vote on banning |
88 |
> the usage of `default` in src_install() directly from ebuilds? The |
89 |
> syntax back and forth converting MUST stop. |
90 |
> |
91 |
> - Samuli |
92 |
> |
93 |
What is the problem with "default" in src_install? |
94 |
|
95 |
- -- |
96 |
Regards, |
97 |
Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2 |
98 |
-----BEGIN PGP SIGNATURE----- |
99 |
Version: GnuPG v2.0.19 (GNU/Linux) |
100 |
|
101 |
iQIcBAEBCgAGBQJPyx3BAAoJEPqDWhW0r/LCDU8P/0CAf/WNo/QXy4+sDWZ+yi1X |
102 |
w3OYURV1MC31SvuzP2WLUruiMokDVe2n8h64yMG8F2/CCcPfBpKKF0mWZilx+F3O |
103 |
+kDZLRBApf4sinuKLPkicGFaFQl21jYphTJPr6blaYf5VPZZp6/lgYR6Tj2R9a21 |
104 |
gj9evIg/GajZF+JBc3t/R7Ijw+W3DBvBokEmJ9RbPI05hvaAjFKK9tN1Sk2Hk/aq |
105 |
ntKS1CDuD4JCQaJpSSvmKZZPotrddy/g0yTdfri8aol6hQXIfKxNoDW4DEwAMsAj |
106 |
d1u92qi2Hwha3bK0OrruF5PTvGLdE7SSnQeM1dH+hASX35PXLqET4LE3j4DyCkJF |
107 |
1ttlr9eTIqMSbqiYOZmxaDPJvmgIX8aWxKXnrRS+6jbua92xd7q2ZPdWFBVqSOuH |
108 |
srSwNiJg3pAAgKy5IiJNfWP+TyAgSfZ9gqmJ8uX4MK56iIDT7JWBZ8nY+YPLdx4w |
109 |
vOmsV90Yi20L7NsSP14Dlw1o1AHkoUWQdKC7jqRhYwuGnZ3VENNBMiOZ/G8ro6eY |
110 |
1x3QoXlDCITKofU84F1Tot4yoztWdq/ry/sic29xQ8lJwiH6W8NRV+T7OcFsiPD2 |
111 |
ARoSnIhnDpEbOk8heg1CELTZyKXeZFKaqGdl1I/Sljv5Ai9iKslBOn8OjW5yiK2i |
112 |
Cer7XXMkcBNjiw3aqSxC |
113 |
=tpLH |
114 |
-----END PGP SIGNATURE----- |