1 |
Doug Goldstein wrote: |
2 |
> Alec Warner wrote: |
3 |
>> On 10/15/07, Doug Goldstein <cardoe@g.o> wrote: |
4 |
>>> Jonathan Adamczewski wrote: |
5 |
>>>> Doug Goldstein wrote: |
6 |
>>>>> That's what this commits review list feels like. |
7 |
>>>>> |
8 |
>>>> Nearly every suggestion (from Donnie and others) has been over some |
9 |
>>>> issue that relates directly to either correctness or maintainability. |
10 |
>>>> It doesn't matter if you can "rattle off capabilities to a millimeter" |
11 |
>>>> - if they're not documented somewhere (like, say, in the comments of |
12 |
>>>> the ebuild) then the maintainer that comes after you gets to go and |
13 |
>>>> break it all over again. |
14 |
>>>> |
15 |
>>> Correctness? Fine. Go ahead. Stick $(use_enable xvmc) into the ebuild. |
16 |
>>> Do it. I dare you. Then try to compile. |
17 |
>>> |
18 |
>>> Guess what? When it blows up... that's called INcorrect. The opposite of |
19 |
>>> the right thing. |
20 |
>>> |
21 |
>>> The maintainer who comes after me would be someone with a experience |
22 |
>>> with the package. Some bumkin isn't going to come to maintain package |
23 |
>>> XYZ unless they know or use the package, and guess what? That means |
24 |
>>> experience. |
25 |
>> |
26 |
>> I think this assumption is false. People maintain packages they don't |
27 |
>> know the intricate details of all the time. You are of course, free |
28 |
>> to ignore any and all suggestions offered; but you are not allowed to |
29 |
>> silence them. |
30 |
>> |
31 |
>> -Alec |
32 |
>> |
33 |
> I must have not received my silence/moderate remote control for the |
34 |
> Gentoo mailing lists. Since I haven't received it, I clearly can't |
35 |
> silence anyone on the mailing lists. |
36 |
> |
37 |
Since we're not discussing the technical content any more, but whether the |
38 |
commit reviews should happen at all, I thought i'd bring this to the |
39 |
project list. Please don't take that as criticism: I appreciate many of |
40 |
your peers see "take it to project" as an insult, but it's actually a good |
41 |
thing: you have more latitude to discuss what's annoying you. |
42 |
|
43 |
> I still stand by my original feeling that we'd better the community NOT |
44 |
> only the developers doing the commits by updating the devmanual, which |
45 |
> is accessible to all developers and all users in the Gentoo community. |
46 |
> In addition to updating and cleaning up repoman checks, which is a tool |
47 |
> that everyone in the community can use. This is versus individual |
48 |
> examples in random ebuilds in random e-mails that all have almost an |
49 |
> identical subject on the mailing list. |
50 |
> |
51 |
I agree the devmanual and repoman should be updated, but not that the |
52 |
reviews shouldn't happen. For a start it's interesting to see the ins and |
53 |
outs of ebuilds we'd never otherwise look at, and it's even more |
54 |
interesting to see the stuff that causes an issue, eg an upstream configure |
55 |
script that can't take spaces in prefix. |
56 |
|
57 |
If the reviews bother you, you can surely set a procmail filter which only |
58 |
allows your ones through? |
59 |
|
60 |
> The commits review is flawed because if we're not documenting this stuff |
61 |
> in one central place, then when new developers join. The same lessons |
62 |
> have to be learned over and over again. |
63 |
> |
64 |
Sure, so file a patch to devmanual for stuff that's missing? Or just tell us |
65 |
the rough details here and it can be discussed before some of us lowly |
66 |
users file a patch. |
67 |
|
68 |
> Then again, this depends on the QA guys actually doing something about |
69 |
> the outstanding bugs. |
70 |
Well there'll be an awful lot less bugs hitting user systems now that every |
71 |
ebuild is reviewed and errors are brought to the list, I'd imagine. After |
72 |
all, peer review (or the fear of it ;) is what makes Open-source software |
73 |
such high-quality. |
74 |
|
75 |
Is there a specific area you feel QA is falling down on? If so, please tell |
76 |
the community, and maybe we can help. I know several users who take |
77 |
pleasure in fixing bugs (and don't want the hassle of being a dev) and many |
78 |
more discuss a bug on the forums (often one they've found) before filing a |
79 |
patch. |
80 |
|
81 |
|
82 |
-- |
83 |
gentoo-project@g.o mailing list |