1 |
On 06/03/2012 12:24 PM, Ulrich Mueller wrote: |
2 |
>>>>>> On Sun, 03 Jun 2012, Samuli Suominen wrote: |
3 |
>>>> this one is what I'm really after for: |
4 |
>>> |
5 |
>>>> default for src_install() in EAPI=5 should accept "$@" in correct place |
6 |
>>>> to avoid usage of EXTRA_EMAKE within ebuilds/eclasses and to avoid |
7 |
>>>> duplicating the Portage code for DOCS. |
8 |
>>>> NOTE: When this was last voted on for EAPI=3, we didn't have this DOCS |
9 |
>>>> handling, and this wasn't important yet. |
10 |
>>> |
11 |
>>>> emake DESTDIR="${D}" "$@" install |
12 |
>>> |
13 |
>>> Again, this could be called directly, which has the advantage that it |
14 |
>>> makes it obvious that src_install isn't the default. |
15 |
> |
16 |
>> The difference is working the tree when you have to alter ebuilds which |
17 |
>> have been written like: |
18 |
> |
19 |
>> DOCS=( AUTHORS README.NOW "${FILESDIR}"/README.Gentoo ) |
20 |
> |
21 |
>> src_install() { |
22 |
>> default |
23 |
> |
24 |
>> echo "Some command here." |
25 |
>> } |
26 |
> |
27 |
>> At this point you have to move content of DOCS which may or may not |
28 |
>> rely on the ""quoting with array"". Remove the call to default. And |
29 |
>> then duplicate the EAPI=4 default into the ebuild. |
30 |
> |
31 |
> Why would you have to copy the EAPI 4 src_install code? Apart from |
32 |
> emake, you only need the single line: |
33 |
> dodoc AUTHORS README.NOW "${FILESDIR}"/README.Gentoo |
34 |
> or |
35 |
> dodoc "${DOCS[@]}" |
36 |
> if you want to keep the variable. |
37 |
> |
38 |
> Ulrich |
39 |
> |
40 |
|
41 |
More like 2 lines, first one being the |
42 |
s/default/emake DESTDIR="${D}" htmldir=/path/to/example install/ |
43 |
second one being the DOCS which might in an array or not, with or |
44 |
without quoting or * in place |
45 |
|
46 |
Then do this multiple times by month all over the tree :/ |
47 |
|
48 |
And I did mention it makes the default EAPI=4 src_install() useless for |
49 |
eclasses due to lack of support for the arguments too? |
50 |
|
51 |
When all there is required is dropping some "$@" to the Portage code and |
52 |
be done with it, and have everything be in consistent format... |
53 |
|
54 |
- Samuli |