1 |
On 06/03/2012 11:18 AM, Markos Chandras wrote: |
2 |
> -----BEGIN PGP SIGNED MESSAGE----- |
3 |
> Hash: SHA512 |
4 |
> |
5 |
> On 06/03/2012 04:26 AM, Samuli Suominen wrote: |
6 |
>> On 06/03/2012 06:20 AM, Samuli Suominen wrote: |
7 |
>>> On 06/03/2012 03:01 AM, Ulrich Mueller wrote: |
8 |
>>>>>>>>> On Sun, 03 Jun 2012, Samuli Suominen wrote: |
9 |
>>>> |
10 |
>>>>>> On 05/29/2012 10:09 AM, Fabian Groffen wrote: |
11 |
>>>>> http://archives.gentoo.org/gentoo-dev/msg_920c6d6daafe7702bfa3b8a2bc21e0c1.xml |
12 |
>>>>> |
13 |
>>>>> |
14 |
>>>> |
15 |
>>>>>> |
16 |
>>>>> |
17 |
> Can you indicate what the council has to vote on/decide for this one? |
18 |
>>>> |
19 |
>>>>> EAPI=5 |
20 |
>>>> |
21 |
>>>>> optional: "$@" placement in default for src_configure() |
22 |
>>>> |
23 |
>>>>> econf "$@" |
24 |
>>>> |
25 |
>>>>> optional: "$@" placement in default for src_compile() |
26 |
>>>> |
27 |
>>>>> emake "$@" |
28 |
>>>> |
29 |
>>>> I still don't see the point of it. econf or emake could just be |
30 |
>>>> called directly. We won't gain anything by allowing arguments, |
31 |
>>>> but only complicate things. |
32 |
>>>> |
33 |
>>>>> this one is what I'm really after for: |
34 |
>>>> |
35 |
>>>>> default for src_install() in EAPI=5 should accept "$@" in |
36 |
>>>>> correct place to avoid usage of EXTRA_EMAKE within |
37 |
>>>>> ebuilds/eclasses and to avoid duplicating the Portage code |
38 |
>>>>> for DOCS. NOTE: When this was last voted on for EAPI=3, we |
39 |
>>>>> didn't have this DOCS handling, and this wasn't important |
40 |
>>>>> yet. |
41 |
>>>> |
42 |
>>>>> emake DESTDIR="${D}" "$@" install |
43 |
>>>> |
44 |
>>>> Again, this could be called directly, which has the advantage |
45 |
>>>> that it makes it obvious that src_install isn't the default. |
46 |
>>> |
47 |
>>> The difference is working the tree when you have to alter ebuilds |
48 |
>>> which have been written like: |
49 |
>>> |
50 |
>>> DOCS=( AUTHORS README.NOW "${FILESDIR}"/README.Gentoo ) |
51 |
>>> |
52 |
>>> src_install() { default |
53 |
>>> |
54 |
>>> echo "Some command here." } |
55 |
>>> |
56 |
>>> At this point you have to move content of DOCS which may or may |
57 |
>>> not rely on the ""quoting with array"". Remove the call to |
58 |
>>> default. And then duplicate the EAPI=4 default into the ebuild. |
59 |
>>> |
60 |
>>> And then replicate that every month dozen times and keep on doing |
61 |
>>> it for some months. Get frustrated. |
62 |
>>> |
63 |
>>> If that's not enough, then you get all excited about EAPI=4 and |
64 |
>>> finally think you have a replacement for base.eclass to port |
65 |
>>> xfconf.eclass away from the thing when you only used it for |
66 |
>>> default src_install() to avoid code duplication... |
67 |
>>> |
68 |
>>> Think you are all done, and then get complainment that support |
69 |
>>> for extra arguments for xfconf_src_install was killed, and was |
70 |
>>> required for things like: |
71 |
>>> |
72 |
>>> xfconf_src_install htmldirectory=/usr/share/doc/${PF}/html |
73 |
>>> imagesdir=/usr/share/doc/${PF}/html/images |
74 |
>>> |
75 |
>>> Where sedding the build system runs maintainer mode at .in level, |
76 |
>>> and runnning autotools (.am level) requires heavy documentation |
77 |
>>> dependencies. You go back to base.eclass and get frustrated |
78 |
>>> more. |
79 |
>>> |
80 |
>>> I hope that clears things up ;-) |
81 |
>>> |
82 |
>> |
83 |
>> Also, if not implemented, what is the replacement for EXTRA_EMAKE |
84 |
>> which we are allowed to use from ebuilds? Or are we allowed to use |
85 |
>> it? I think PMS didn't forbid it the last time I checked and it has |
86 |
>> consumers in tree already. |
87 |
>> |
88 |
>> And if not implemented, would the council please vote on banning |
89 |
>> the usage of `default` in src_install() directly from ebuilds? The |
90 |
>> syntax back and forth converting MUST stop. |
91 |
>> |
92 |
>> - Samuli |
93 |
>> |
94 |
> What is the problem with "default" in src_install? |
95 |
|
96 |
Did you not read the mail at all? The lack of support for arguments |
97 |
makes it useless, and even harmful/annoying when you have to convert |
98 |
them constantly around the tree |
99 |
|
100 |
-Samuli |