| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA512 |
| 3 |
|
| 4 |
On 09/19/11 17:27, Fabian Groffen wrote: |
| 5 |
> On 19-09-2011 16:44:51 +0300, Markos Chandras wrote: |
| 6 |
>> On 09/19/11 16:26, Fabian Groffen wrote: |
| 7 |
>>> I would prefer going this route myself. Generate all |
| 8 |
>>> ChangeLogs from commit messages only. This is easy to |
| 9 |
>>> implement (POC is running for Prefix), but has a little issue |
| 10 |
>>> with ChangeLog being in Manifest file. I think we should just |
| 11 |
>>> omit it, or (better) allow the Manifest to have multiple signed |
| 12 |
>>> parts, such that the ebuilds, dists and files are signed by the |
| 13 |
>>> committing developer, and the ChangeLog is signed by the |
| 14 |
>>> generation process (like snapshots are). |
| 15 |
>> If you generate Changelogs from commit messages then you dont |
| 16 |
>> need to place the to $VCS unless you want to edit them ( see |
| 17 |
>> below ) |
| 18 |
> |
| 19 |
> I can't parse/don't understand this sentence. Could you |
| 20 |
> explain/elaborate? |
| 21 |
Yeah it is obvious that I can't type. What I meant was that if we use |
| 22 |
the commit logs to generate the ChangeLogs then we can do that on |
| 23 |
server side (just before populating the portage tree to rsync |
| 24 |
mirrors). In this case we do not need to store the Changelog files on |
| 25 |
$VCS. |
| 26 |
> |
| 27 |
>>> The council has, however, (like Markos' initial mail |
| 28 |
>>> explained) decided that ChangeLog entries must be updatable |
| 29 |
>>> (e.g. corrected) afterwards. |
| 30 |
>> Really? when? There is no decision on this topic yet[1](3rd |
| 31 |
>> bullet point). If I am wrong, please point me to the correct |
| 32 |
>> source. I thought this discussion is about whether we want to |
| 33 |
>> edit them afterwards or not. So unless we decide to edit them, we |
| 34 |
>> don't need ChangeLog files |
| 35 |
> |
| 36 |
> Sorry, I recalled the details wrong. The effect is the same |
| 37 |
> though, a file needs to exist: |
| 38 |
> |
| 39 |
> [quote from [1]] - Vote: Retroactively change existing entries, yes |
| 40 |
> or no. - We will append to changelogs and retain all existing |
| 41 |
> changelog messages. [/quote from [1]] |
| 42 |
> |
| 43 |
|
| 44 |
Yes a file is needed but like I said before, this file can be |
| 45 |
generated on a post-commit server just before populating portage to |
| 46 |
rsync servers |
| 47 |
|
| 48 |
> An additional advantage of keeping the file is that we can easily |
| 49 |
> fix all entries that people wrote/committed ugly and helpless |
| 50 |
> messages for, like "^" and so on. |
| 51 |
> |
| 52 |
In this case you need smart filtering tools to avoid duplicate |
| 53 |
messages ( one from $commit_message and the one you wrote yourself to |
| 54 |
fix that message ). However, this will be the case if we decide to |
| 55 |
allow edits on ChangeLogs. |
| 56 |
|
| 57 |
- -- |
| 58 |
Regards, |
| 59 |
Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2 |
| 60 |
-----BEGIN PGP SIGNATURE----- |
| 61 |
Version: GnuPG v2.0.18 (GNU/Linux) |
| 62 |
|
| 63 |
iQIcBAEBCgAGBQJOd22rAAoJEPqDWhW0r/LC8iYP/3rbJ0SaHFL8FWnOBeVP2AUH |
| 64 |
WmtCJnJxoMaiktLVTQHFflFJb28MYKKC9Gytox3pubGdvOO2/8cqNIjR/qT+G+xj |
| 65 |
pOrp71ikgOmJwjkuN6UtcuqCFNpwLpWnOt1i9FZ/tlJeY3ihFPpMLA+768QKgUDf |
| 66 |
c3qtchSQR4By/sVEp+0WYQcybFSOez7HMtpxzrT2mwBMK2nE5AfrqczsuXnbdVi4 |
| 67 |
8Q+VQKdM6PGaawrDUb7yz6Jx+jyIhfmJc/xun/cPa0xXUpSN3LuBnLDpW6JOJNFo |
| 68 |
UfFNylmxTCJevf5R5oGSC80TEhGbm7Dit/SWRmo/dzut67uXDTqBr4nTDY0KmAZu |
| 69 |
wJdiNuWA4UThWk7F/86DRooRH5xyqxoLFcEphrgq9mR+uQDv5W7OAwn0YqVZoQCS |
| 70 |
wY3YeAVHPFnKU965/QTwJz/K7vOYVvkRahkP1yRFMv7bYGmpdYzewa0ycN/sYIuC |
| 71 |
vC4wwkEhhOBr+ymdozka46gc2ucXpL6YyfJADZuvQQW6f/zcqjWJN0nDwaN8jRf2 |
| 72 |
ULY+HzfOOSKmGUsi7JY5tHJnneB9TkzOTao0oz2w5M/OGTqJfIHGOhXGtgjTBOf4 |
| 73 |
yjzPytdkVmq7A3P8A0CnZicdFv+6UfEYFSeXgX4MPrDE0FaZFx9T80RCljn71rXx |
| 74 |
YTGqLdK/OxXJ1kRnkGea |
| 75 |
=08+b |
| 76 |
-----END PGP SIGNATURE----- |
Archives