Gentoo Archives: gentoo-python

From: Mike Gilbert <floppym@g.o>
To: gentoo-python@l.g.o
Subject: Re: [gentoo-python] [PATCH] Support -A / --ABIs-patterns option in python_mod_optimize() and python_mod_cleanup()
Date: Thu, 29 Dec 2011 14:49:36
Message-Id: 4EFC7DF7.70705@gentoo.org
In Reply to: Re: [gentoo-python] [PATCH] Support -A / --ABIs-patterns option in python_mod_optimize() and python_mod_cleanup() by Mike Gilbert
On 12/29/2011 09:26 AM, Mike Gilbert wrote:
> On 12/29/2011 09:06 AM, Michał Górny wrote: >> On Thu, 29 Dec 2011 08:50:11 -0500 >> Mike Gilbert <floppym@g.o> wrote: >> >>> On 12/29/2011 08:41 AM, Michał Górny wrote: >>>> On Thu, 29 Dec 2011 08:08:26 -0500 >>>> Mike Gilbert <floppym@g.o> wrote: >>>> >>>>> This patch allows python_mod_optimize to be used in cases where a >>>>> different set of python modules is installed depending on the >>>>> python abi. >>>>> >>>>> For example, dev-python/feedparse-5.1 (not yet in the tree) >>>>> installs the _feedparser_sgmllib.py module only in python-3*. >>>> >>>> Could you paste some example on how it is supposed to be used? >>>> >>> >>> Sure. Borrowed from feedparser-5.1.ebuild in Progress: >>> >>> pkg_postinst() { >>> python_mod_optimize -A "2.*" feedparser.py >>> python_mod_optimize -A "3.*" feedparser.py _feedparser_sgmllib.py >>> } >>> >>> pkg_postrm() { >>> python_mod_cleanup -A "2.*" feedparser.py >>> python_mod_cleanup -A "3.*" feedparser.py _feedparser_sgmllib.py >>> } >> >> Ok, now that I see it, I think you're inventing a really big hammer to >> get rid of a single mosquito. >> > > I don't think the hammer is really that big; it seems like a relatively > small extension to me. The code for checking ABI patterns is already > there, this just wires it up to a couple of additional functions. > > I actually think it would make more sense to call python_mod_optimize > using python_execute_function, but I think that would require a > backward-incompatible API change. >
On second thought, most of python_mod_optimize could be refactored into a new function (python_mod_optimize_abi?) that would be called once per ABI by python_execute_function. So, please disregard that last comment. </tangent>

Attachments

File name MIME type
signature.asc application/pgp-signature