Re: [gentoo-python] recent trend of django-foo tests

[Mike Gilbert]

On Mon, May 20, 2013 at 1:36 PM, IAN DELANEY <della5@×××××××××.au> wrote:
> On Mon, 20 May 2013 13:18:53 +0400
> "Nikolaj Sjujskij" <sterkrig@×××××××.com> wrote:
>
>> Den 2013-05-20 13:05:33 skrev IAN DELANEY <della5@×××××××××.au>:
>>
>>     ...
>> -c cmd : program passed in as string (_terminates option list_)
>>
>> So ${test} seems to be ignored or misinterpreted.
>>
>>
>> You could try creating ./global_settings.py in :
>>
>>      from django.conf import global_settings
>>      global_settings.SECRET_KEY='green'
>>
>>      print(global_settings)   # testing purposes!
>>
>> Now:
>>   % python -c 'import global_settings'
>> <module 'django.conf.global_settings' from
>> '/usr/lib64/python2.7/site-packages/django/conf/global_settings.pyc'>
>
> Ja, tack tack for att forsoka, med nej. (Please add the grammatical
> nice-ities to the vowel o).  I got a fix from #django on the second
> attempt. I was close on the first attempt, so for the benefit of all,
>
> first export SECRET_KEY='green', followed by
>
> -    "from django.conf import \
>   global_settings;global_settings.SECRET_KEY='green'" ${test}
> +    "from django.conf import \
>   global_settings;global_settings.SECRET_KEY='$SECRET_KEY'" ${test}
>
> and presto.
>
>  * python2_7: running distutils-r1_run_phase python_test
>  * test test_compiler.py passed under python2.7
>  * test test_compressor.py passed under python2.7
>
> another bug bites the dust.
>

Ian:

You have NOT fixed a bug; rather you have masked one. As Nikolaj
indicates, python -c "code" foo.py does NOT run foo.py.

The change you have made causes the tests to be skipped entirely. A
message stating "tests passed" does not signify that anything was
actually run.

If you cannot figure this out, please remove python_test from any
ebuilds you have modified. At least that way we don't give the false
impression that the tests have actually passed.