Gentoo Archives: gentoo-python

From: Mike Gilbert <floppym@g.o>
To: gentoo-python@l.g.o
Subject: [gentoo-python] [PATCH] python.eclass: Avoid multiple inclusion
Date: Thu, 29 Dec 2011 21:18:14
Message-Id: 4EFCD90C.3010309@gentoo.org
Mike's doing it in autotools.eclass, so let's do it too.

This will aid in debugging code in global scope and prevent duplicate
dependency atoms from being generated. Also, per vapier[1], it could
have some performance enhancing qualities.

The distutils part avoids sourcing python.eclass if distutils is
inherited after python. We can add similar blocks to other eclass
consumers of python.eclass.

I think it's a good idea, and you should to.

Please see attached patch. Please let me know you have some objection;
otherwise I will commit on Sunday, Jan 1.

[1]
http://archives.gentoo.org/gentoo-dev/msg_18dab542c1c59873f8cb68c96cdf6619.xml

Attachments

File name MIME type
python-eclass-multiple-inclusion.patch text/x-patch
signature.asc application/pgp-signature