Re: [gentoo-python] [PATCH 2/6] [python-any-r1] do not use has_version() for interpreter checks.

[Michał Górny]

Dnia 2013-07-22, o godz. 11:51:15
Michał Górny <mgorny@g.o> napisał(a):

> has_version() can't handle any-of deps, and I see no point in
> introducing special magic to handle pypy-bin there. Instead, just check
> if the interpreter executable is installed. It is simpler and faster
> this way.
> ---
>  gx86/eclass/python-any-r1.eclass | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gx86/eclass/python-any-r1.eclass b/gx86/eclass/python-any-r1.eclass
> index aa11cf7..b392453 100644
> --- a/gx86/eclass/python-any-r1.eclass
> +++ b/gx86/eclass/python-any-r1.eclass
> @@ -176,9 +176,10 @@ _python_EPYTHON_supported() {
>  	esac
>
>  	if has "${i}" "${PYTHON_COMPAT[@]}"; then
> -		local PYTHON_PKG_DEP
> -		python_export "${i}" PYTHON_PKG_DEP
> -		if ROOT=/ has_version "${PYTHON_PKG_DEP}"; then
> +		local PYTHON
> +		python_export PYTHON
> +
> +		if [[ -x ${PYTHON} ]]; then
>  			if declare -f python_check_deps >/dev/null; then
>  				local PYTHON_USEDEP="python_targets_${i}(-),python_single_target_${i}(+)"
>  				python_check_deps

marienz noticed that the previous version enforced PYTHON_REQ_USE
and the new one doesn't. Let's discard this patch then and look for
a better solution.

-- 
Best regards,
Michał Górny