| 1 |
On Tue, Jan 21, 2014 at 09:04:56AM -0800, Sébastien Fabbro wrote: |
| 2 |
> On Mon, Jan 20, 2014 at 9:53 AM, Reinis Danne <rei4dan@×××××.com> wrote: |
| 3 |
> |
| 4 |
> > |
| 5 |
> > I have cleaned up a bit alternatives-2.eclass to make it easier to review. |
| 6 |
> > Also if someone knows any shortcommings of this eclass as it is, then point |
| 7 |
> > it out, I'll try to address them. |
| 8 |
> > |
| 9 |
> > I hope this can be soon moved to the main tree thus closing the divide |
| 10 |
> > between |
| 11 |
> > science overlay and portage tree. |
| 12 |
> > |
| 13 |
> |
| 14 |
> |
| 15 |
> Your changes are mostly minor and only apply to the eclass, so I have no |
| 16 |
> comments. You should commit them to the overlay, code reviews on the github |
| 17 |
> review panel are more practical than on the mailing list. |
| 18 |
> One important thing the creation of eselect modules could be done directly |
| 19 |
> from eselect rather than the eclass, keeping the eclass much more simple, |
| 20 |
> and allowing users to create their own providers easily. I may work on it. |
| 21 |
> I had some local changes of eselect and I added the repo [1] to the github |
| 22 |
> gentoo-science, that you can test by unmasking eselect-9999. |
| 23 |
|
| 24 |
How the eselect module creation could work? Something like this? |
| 25 |
|
| 26 |
~# eselect module create blas |
| 27 |
~# eselect blas add atlas importance src dest [src dest [..]] |
| 28 |
... |
| 29 |
~# eselect blas remove atlas |
| 30 |
~# eselect delete blas |
| 31 |
|
| 32 |
> |
| 33 |
> Known issues of the alternatives framework: |
| 34 |
> * when having more than 1 provider, updating a package that provided the |
| 35 |
> eselected provider, will not re-eselect the same provider unless it was the |
| 36 |
> first on the list |
| 37 |
|
| 38 |
Fixed by "alternatives-2.eclass: Fix check for uninstalling". |
| 39 |
|
| 40 |
> * possible residual orphan files |
| 41 |
|
| 42 |
Haven't observed any after my patch series applied. |
| 43 |
|
| 44 |
> * given the number of bugs, we should keep the linking to the reference |
| 45 |
> names libraries, so we could eselect providers without re-compiling all |
| 46 |
> reverse dependencies. We could do this in the open sourced providers by |
| 47 |
> changing the soname of the libraries we compile, and in the binary ones |
| 48 |
> (mkl,amcl...) with a link script generated library. |
| 49 |
|
| 50 |
Yes, this is ok and AFAICT it is like that now in the overlay. |
| 51 |
|
| 52 |
> |
| 53 |
> |
| 54 |
> [1] https://github.com/gentoo-science/eselect |
| 55 |
> |
| 56 |
> Sebastien |
Archives