| 1 |
On 20/01/14 18:53, Reinis Danne wrote: |
| 2 |
> Hi! |
| 3 |
> |
| 4 |
> I have cleaned up a bit alternatives-2.eclass to make it easier to review. |
| 5 |
> Also if someone knows any shortcommings of this eclass as it is, then point |
| 6 |
> it out, I'll try to address them. |
| 7 |
> |
| 8 |
> I hope this can be soon moved to the main tree thus closing the divide between |
| 9 |
> science overlay and portage tree. |
| 10 |
> |
| 11 |
> Reinis Danne (10): |
| 12 |
> alternatives-2.eclass: Update copyright |
| 13 |
> alternatives-2.eclass: Remove unused variables |
| 14 |
> alternatives-2.eclass: Move EXPORT_FUNCTIONS to top |
| 15 |
> alternatives-2.eclass: Remove commented-out code |
| 16 |
> alternatives-2.eclass: Put commonly used path in local variable |
| 17 |
> alternatives-2.eclass: Fix eclass name in comments |
| 18 |
> alternatives-2.eclass: Add EAPI check |
| 19 |
> alternatives-2.eclass: Add documentation comments |
| 20 |
> alternatives-2.eclass: Minor comment changes |
| 21 |
> alternatives-2.eclass: Use consistent quoting |
| 22 |
> |
| 23 |
> eclass/alternatives-2.eclass | 110 +++++++++++++++++++++++++++++++------------ |
| 24 |
> 1 file changed, 79 insertions(+), 31 deletions(-) |
| 25 |
> |
| 26 |
|
| 27 |
Thanks for all your work. |
| 28 |
|
| 29 |
Sebastien, Dennis, Ulrich and everybody else, let's gather a list of the |
| 30 |
remaining issue to resolve. |
| 31 |
|
| 32 |
|
| 33 |
Reinis, could you branch the sci overlay on github and and push your |
| 34 |
changes there. Everybody, let's stick to clear commit msgs for the |
| 35 |
eclass so that the review goes easy. |
| 36 |
|
| 37 |
Justin |
| 38 |
|
| 39 |
P.s. Sorry guys for CCing you directly. I am not sure if you are all |
| 40 |
following the list. |
Archives