Gentoo Archives: gentoo-scm

From: Alec Warner <antarus@g.o>
To: Donnie Berkholz <dberkholz@g.o>
Cc: Mike Auty <ikelos@g.o>, gentoo-scm@l.g.o
Subject: Re: [gentoo-scm] repoman patch for git support (from drobbins)
Date: Sun, 16 Nov 2008 21:49:39
Message-Id: b41005390811161349j44998fbdhd63bf98b76455eff@mail.gmail.com
In Reply to: Re: [gentoo-scm] repoman patch for git support (from drobbins) by Donnie Berkholz
On Sun, Nov 16, 2008 at 9:20 AM, Donnie Berkholz <dberkholz@g.o> wrote:
> On 01:34 Sun 16 Nov , Alec Warner wrote: >> Change the workflow[1]. >> >> Right now you pay the cost of running tree-wide tests every time you >> commit. This incentivizes developers to commit less often (to avoid >> paying the tax of tree-wide tests). >> >> In CVS commiting less is a problem: >> >> 1. Make Changes to a number of files. >> 2. Script your commits. >> 3. Run Script >> 4....N: Script commits one file at a time. >> 4.5: A race condition between changes you have commited to CVS versus >> uncommited changes occurs when CVS is synced to Osprey. This race >> condition can often cause tree oddness. >> 5. All Changes commited. >> 5.5: All changes synced to Osprey. >> >> I am unsure if repoman category and repoman tree-wide commits avoid >> this race condition. >> >> A new scheme would be: >> >> 1. Make Changes to a number of files. >> 2. Category or Treewide Repoman commit. >> 3. Run taxing tree-wide tests. >> 4. git commit -a (?) >> 5. Done! >> >> Tell me if I'm horribly wrong or missing something, it is late here. > > Are you saying we could use the index here? Another option (that you may > or may not be suggesting) could be to make a new 'repoman push' > operation that actually does the hard checks, and make 'repoman commit' > just do a local commit and only very quick checks.
That was what I was thinking.
> > -- > Thanks, > Donnie > > Donnie Berkholz > Developer, Gentoo Linux > Blog: http://dberkholz.wordpress.com >