public inbox for gentoo-pms@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-pms@lists.gentoo.org
Cc: ciaran.mccreesh@googlemail.com
Subject: Re: [gentoo-pms] Write to filesystem in pkg_* phases
Date: Sun, 15 Jun 2014 09:53:02 +0200	[thread overview]
Message-ID: <20140615095302.2fa17956@pomiot.lan> (raw)
In-Reply-To: <20140602154704.3a24a62f@googlemail.com>

[-- Attachment #1: Type: text/plain, Size: 1607 bytes --]

Dnia 2014-06-02, o godz. 15:47:04
Ciaran McCreesh <ciaran.mccreesh@googlemail.com> napisał(a):

> On Mon, 2 Jun 2014 11:42:07 +0200
> Ulrich Mueller <ulm@gentoo.org> wrote:
> > This topic was already discussed in -dev some time ago [1], but went
> > nowhere at the time. Now it came up again in bug 469210 [2].
> > (Ironically, checking for a particular kernel configuration is the
> > example mentioned in the spec for pkg_pretend.)  
> 
> That's not ironic! It's not the spec's fault that people write lousy
> eclasses.

It is the spec's fault when it sets stupid and mismatched
requirements. As long as we don't restrict pkg_* phases from calling
external tools, prohibiting writes to temporary directory is just
pointless. Every semi-sane system has a writable temporary directory
that can be used freely by random programs, and so shall ebuild
environment have.

As for pkg_pretend(), I don't have a strong opinion whether it should
be added to use external tools. However, prohibiting that would limit
its use a lot. As for remaining pkg_*() phases, I think such
prohibition would simply make the phases purposeless.

As for ${T}, I consider it simply a convenient directory which ebuild
can use for temporary files without needing to care about unique names
and cleaning up afterwards. Prohibiting writes there during
pkg_pretend() would be a minor inconvenience but may save the effort of
preparing a separate temporary directory before build/install starts.
However, I don't think the confusion caused by it outweighs the benefit.

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

  parent reply	other threads:[~2014-06-15  7:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02  9:42 [gentoo-pms] Write to filesystem in pkg_* phases Ulrich Mueller
2014-06-02 14:47 ` Ciaran McCreesh
2014-06-02 15:47   ` Ulrich Mueller
2014-06-15  7:53   ` Michał Górny [this message]
2014-06-15 13:45     ` Ciaran McCreesh
2014-06-15 13:58       ` Michał Górny
2020-06-26 10:39 ` [gentoo-pms] [PATCH] " Ulrich Mueller
2020-07-05 19:04   ` Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140615095302.2fa17956@pomiot.lan \
    --to=mgorny@gentoo.org \
    --cc=ciaran.mccreesh@googlemail.com \
    --cc=gentoo-pms@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox