From: Joonas Niilola <juippis@gentoo.org>
To: gentoo-proxy-maint@lists.gentoo.org
Subject: Re: [gentoo-proxy-maint] [PATCH 4/4] net-irc/ii: flesh out ebuild
Date: Fri, 7 May 2021 15:54:29 +0300 [thread overview]
Message-ID: <aa7172ae-8e2c-30f9-0c66-d8435eecffa5@gentoo.org> (raw)
In-Reply-To: <20210417165202.9809-4-fulade@riseup.net>
[-- Attachment #1.1: Type: text/plain, Size: 3593 bytes --]
Hey,
merged, thanks! I squashed your commits 2-4 to a single one, and added
the CFLAGS sed's back due to:
* Messages for package net-irc/ii-1.8:
* Log file:
/var/tmp/portage/vbslogs/build/net-irc/ii-1.8:20210507-122242.log
* QA Notice: Files built without respecting CFLAGS have been detected
* Please include the following list of files in your report:
* /usr/bin/ii
* Messages for package net-irc/ii-9999:
* Log file:
/var/tmp/portage/vbslogs/build/net-irc/ii-9999:20210507-122233.log
* QA Notice: Files built without respecting CFLAGS have been detected
* Please include the following list of files in your report:
* /usr/bin/ii
In future you can use
https://wiki.gentoo.org/wiki/Package_testing#make.conf these settings to
test your ebuilds and see these QA notices.
-- juippis
On 17.4.2021 19.52, Vladimir Kuznetsov wrote:
> Package-Manager: Portage-3.0.17, Repoman-3.0.2
> Signed-off-by: Vladimir Kuznetsov <fulade@riseup.net>
> ---
> net-irc/ii/ii-1.8.ebuild | 17 ++++++-----------
> net-irc/ii/ii-9999.ebuild | 18 ++++++------------
> 2 files changed, 12 insertions(+), 23 deletions(-)
>
> diff --git a/net-irc/ii/ii-1.8.ebuild b/net-irc/ii/ii-1.8.ebuild
> index 8602091e7e7..5ef9e5bdca9 100644
> --- a/net-irc/ii/ii-1.8.ebuild
> +++ b/net-irc/ii/ii-1.8.ebuild
> @@ -1,36 +1,31 @@
> # Copyright 1999-2021 Gentoo Authors
> # Distributed under the terms of the GNU General Public License v2
>
> EAPI=7
> inherit toolchain-funcs
>
> DESCRIPTION="A minimalist FIFO and filesystem-based IRC client"
> HOMEPAGE="https://tools.suckless.org/ii/"
> SRC_URI="https://dl.suckless.org/tools/${P}.tar.gz"
>
> LICENSE="MIT"
> SLOT="0"
> KEYWORDS="amd64 arm ~arm64 ~ppc ~ppc64 x86 ~amd64-linux"
>
> src_prepare() {
> default
>
> - sed -i \
> - -e '/^CFLAGS/{s: -Os::g; s:= :+= :g}' \
> - -e '/^CC/d' \
> - -e '/^LDFLAGS/{s:-s::g; s:= :+= :g}' \
> - config.mk || die
> - sed -i \
> - -e 's|@${CC}|$(CC)|g' \
> - Makefile || die
> + sed -i -e '/^LDFLAGS/{s:-s::g; s:= :+= :g}' config.mk || die
> }
>
> src_compile() {
> emake CC="$(tc-getCC)"
> }
>
> src_install() {
> - dobin ii
> - dodoc CHANGES FAQ README
> - doman *.1
> + emake \
> + DESTDIR="${D}" \
> + PREFIX="${EPREFIX}"/usr \
> + DOCDIR="${EPREFIX}"/usr/share/doc/${PF} \
> + install
> }
> diff --git a/net-irc/ii/ii-9999.ebuild b/net-irc/ii/ii-9999.ebuild
> index db00b6528aa..4ba2eac0c28 100644
> --- a/net-irc/ii/ii-9999.ebuild
> +++ b/net-irc/ii/ii-9999.ebuild
> @@ -1,36 +1,30 @@
> # Copyright 1999-2021 Gentoo Authors
> # Distributed under the terms of the GNU General Public License v2
>
> EAPI=7
> inherit git-r3 toolchain-funcs
>
> DESCRIPTION="A minimalist FIFO and filesystem-based IRC client"
> HOMEPAGE="https://tools.suckless.org/ii/"
> EGIT_REPO_URI="https://git.suckless.org/ii"
>
> LICENSE="MIT"
> SLOT="0"
> -KEYWORDS=""
>
> src_prepare() {
> default
>
> - sed -i \
> - -e '/^CFLAGS/{s: -Os::g; s:= :+= :g}' \
> - -e '/^CC/d' \
> - -e '/^LDFLAGS/{s:-s::g; s:= :+= :g}' \
> - config.mk || die
> - sed -i \
> - -e 's|@${CC}|$(CC)|g' \
> - Makefile || die
> + sed -i -e '/^LDFLAGS/{s:-s::g; s:= :+= :g}' config.mk || die
> }
>
> src_compile() {
> emake CC="$(tc-getCC)"
> }
>
> src_install() {
> - dobin ii
> - dodoc CHANGES FAQ README
> - doman *.1
> + emake \
> + DESTDIR="${D}" \
> + PREFIX="${EPREFIX}"/usr \
> + DOCPREFIX="${EPREFIX}"/usr/share/doc/${PF} \
> + install
> }
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
prev parent reply other threads:[~2021-05-07 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 16:51 [gentoo-proxy-maint] [PATCH 1/4] net-irc/ii: add myself to maintainers Vladimir Kuznetsov
2021-04-17 16:52 ` [gentoo-proxy-maint] [PATCH 2/4] net-irc/ii: fix copyright header Vladimir Kuznetsov
2021-04-17 16:52 ` [gentoo-proxy-maint] [PATCH 3/4] net-irc/ii: bump eapi to 7 Vladimir Kuznetsov
2021-04-17 16:52 ` [gentoo-proxy-maint] [PATCH 4/4] net-irc/ii: flesh out ebuild Vladimir Kuznetsov
2021-05-07 12:54 ` Joonas Niilola [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa7172ae-8e2c-30f9-0c66-d8435eecffa5@gentoo.org \
--to=juippis@gentoo.org \
--cc=gentoo-proxy-maint@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox