Re: [eudev] [PATCH 1/3] shared: typecast away 'const' qualifier from pointer

[Marcus Folkesson]

On Sun, Feb 18, 2018 at 09:58:19PM -0500, Anthony G. Basile wrote:
> On 2/18/18 2:47 PM, Marcus Folkesson wrote:
> > Get rid of this warning:
> >  warning: passing argument 1 of ‘__xpg_basename’ discards ‘const’
> >  qualifier from pointer target type [-Wdiscarded-qualifiers]
> >           fn = basename(p);
> >
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@×××××.com>
> > ---
> >  src/shared/util.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/shared/util.c b/src/shared/util.c
> > index ac69ae80e..9e36050a0 100644
> > --- a/src/shared/util.c
> > +++ b/src/shared/util.c
> > @@ -1726,7 +1726,7 @@ int tempfn_xxxxxx(const char *p, char **ret) {
> >           *         /foo/bar/.#waldoXXXXXX
> >           */
> >
> > -        fn = basename(p);
> > +        fn = basename((char*)p);
> >          if (!filename_is_valid(fn))
> >                  return -EINVAL;
> >
>
>
> This fix is already in there.

You are right, my git-fu seems to have degraded yesterday.

It is not the first time I create a local branch called "origin/master"
by mistake.
Seems like I have done it for my systemd repo too.

I thought this warning was familiar...

>
> --
> Anthony G. Basile, Ph.D.
> Gentoo Linux Developer [Hardened]
> E-Mail    : basile@××××××××××.net
> GnuPG FP  : 1FED FAD9 D82C 52A5 3BAB  DC79 9384 FA6E F52D 4BBA
> GnuPG ID  : F52D4BBA
>
>