1 |
On Wed, 2008-08-06 at 17:44 +0200, Fabian Groffen wrote: |
2 |
> You skip the OPTS="${CFLAGS}" here, has that any reason? Feels like |
3 |
> this was necessary to make the build system respect our CFLAGS. |
4 |
The patch works for me as well when not skipping the OPTS="${CFLAGS}", |
5 |
but this leads to a needless duplication of some define flags during |
6 |
compilation. I didn't trace it down too long, probably there is an |
7 |
equivalent patch that doesn't touch the OPTS="${CFLAGS}", but it looks |
8 |
quite redundant once we are employing 'append-flags ...', right? |
9 |
|
10 |
On Wed, 2008-08-06 at 10:32 -0500, Jeremy Olexa wrote: |
11 |
> On Wed, Aug 6, 2008 at 10:25 AM, <rabbe@×××××××.se> wrote: |
12 |
> > * Aborting due to QA concerns: there are files installed outside the |
13 |
> > prefix |
14 |
> > * Call stack: |
15 |
> > * misc-functions.sh:822: <call install_qa_check> |
16 |
> > * misc-functions.sh:288: die "Aborting due |
17 |
> > to QA concerns: there are files ins |
18 |
> > talled outside the prefix" |
19 |
> |
20 |
> The Makefile in the po/ directory doesn't honor $prefix like the |
21 |
> Makefile does one directory above it. Hence, the source of this |
22 |
> problem. |
23 |
Yeah, this is part of what I meant with "2) NLS not working". However |
24 |
fixing this obvious problem (INSTALLNLSDIR) is not enough as you can see |
25 |
with my patch. Fixing the main Makefile (LOCALEDIR) is necessary, too, |
26 |
to inform {whois,mkpasswd}.c about where the locales can be found. |
27 |
|
28 |
> I think this patch could go upstream to |
29 |
> gentoo-x86. Even though they won't have this bug there, it may be a |
30 |
> good idea to fix anyway. |
31 |
That's right. They simply did not notice this problem because they |
32 |
always install to /usr/... but they are intrinsically affected anyway. |
33 |
|
34 |
|
35 |
Marius |