| 1 |
On Sat, 2 Jan 2010, Jeremy Olexa wrote: |
| 2 |
|
| 3 |
> On Fri, 01 Jan 2010 18:53:12 -0600 (CST), mattmatteh@×××.com wrote: |
| 4 |
>> thought i would take a look at the games that need patching with |
| 5 |
>> #${EPREFIX}. using bug http://bugs.gentoo.org/show_bug.cgi?id=296987 as |
| 6 |
> |
| 7 |
>> an example, i removed the fix to verify the failure and added einfo to |
| 8 |
> see |
| 9 |
>> whats going on: |
| 10 |
>> |
| 11 |
>> |
| 12 |
>>>>> Install tuxmath-20010907 into |
| 13 |
>>>>> |
| 14 |
> /Volumes/prefix-ppc-macos-x11/var/tmp/portage/games-kids/tuxmath-20010907/image/Volumes/prefix-ppc-macos-x11/ |
| 15 |
>>>>> category games-kids |
| 16 |
>> * games eclass debug: EPREFIX /Volumes/prefix-ppc-macos-x11 |
| 17 |
>> * games eclass debug: GAMES_PREFIX |
| 18 |
>> /Volumes/prefix-ppc-macos-x11/usr/games |
| 19 |
>> * games eclass debug: GAMES_DATADIR |
| 20 |
>> /Volumes/prefix-ppc-macos-x11/usr/share/games |
| 21 |
>> * games eclass debug: GAMES_DATADIR_BASE |
| 22 |
>> /Volumes/prefix-ppc-macos-x11/usr/share |
| 23 |
>> * games eclass debug: GAMES_SYSCONFDIR |
| 24 |
>> /Volumes/prefix-ppc-macos-x11/etc/games |
| 25 |
>> * games eclass debug: GAMES_STATEDIR |
| 26 |
>> /Volumes/prefix-ppc-macos-x11/var/games |
| 27 |
>> * games eclass debug: GAMES_LOGDIR |
| 28 |
>> /Volumes/prefix-ppc-macos-x11/var/log/games |
| 29 |
>> * games eclass debug: GAMES_LIBDIR |
| 30 |
>> /Volumes/prefix-ppc-macos-x11/usr/games/lib |
| 31 |
>> * games eclass debug: GAMES_BINDIR |
| 32 |
>> /Volumes/prefix-ppc-macos-x11/usr/games/bin |
| 33 |
>> ------------------------------------------------------- |
| 34 |
>> You should not use ${EPREFIX} with helpers. |
| 35 |
>> --> /Volumes/prefix-ppc-macos-x11/usr/share/games/tuxmath |
| 36 |
>> ------------------------------------------------------- |
| 37 |
>> |
| 38 |
>> |
| 39 |
>> soo... i dont see any problem with the install paths, no double prefix. |
| 40 |
>> what is this error about using ${EPREFIX} with helpers? |
| 41 |
>> |
| 42 |
>> before sending i googled and found this |
| 43 |
>> http://www.mail-archive.com/gentoo-alt@l.g.o/msg03335.html |
| 44 |
>> |
| 45 |
>> so it seems that the games eclass should not handle EPREFIX at all ? |
| 46 |
>> |
| 47 |
>> but for confugure those do need to be set since that is whats passed, |
| 48 |
>> econf --prefix="${GAMES_PREFIX}" |
| 49 |
>> |
| 50 |
>> seems like doins needs to stop whinning ? |
| 51 |
>> |
| 52 |
>> matt |
| 53 |
> |
| 54 |
> In general, you should know that do* functions (helpers) set EPREFIX |
| 55 |
> behind the scenes. |
| 56 |
> |
| 57 |
> There are two approaches here. |
| 58 |
> 1) Have EPREFIX in GAMES_PREFIX (eclass) because it is used in ./configure |
| 59 |
> and makes sense to have it there. If you use "do* ${GAMES_PREFIX}/foo" then |
| 60 |
> you have to strip the leading EPREFIX out, such as "do* |
| 61 |
> ${GAMES_PREFIX#${EPREFIX}}/foo" |
| 62 |
> 2) Have GAMES_PREFIX not include EPREFIX and then add it to ./configure |
| 63 |
> --prefix="${EPREFIX}/${GAMES_PREFIX}" |
| 64 |
> |
| 65 |
> Both approaches are in use and it depends on which way "makes the most |
| 66 |
> sense" (less diffs/less work) - I hope that sheds some light on the |
| 67 |
> subject. |
| 68 |
> |
| 69 |
> -Jeremy |
| 70 |
|
| 71 |
i think i am in favor of #2, but have the games.eclass use EPREFIX |
| 72 |
internally where needed. |
| 73 |
|
| 74 |
are there any other eclasses or parts of portage this is or was an issue ? |
| 75 |
|
| 76 |
matt |
Archives