| 1 |
On 12/07/2014 03:04 AM, Ulrich Mueller wrote: |
| 2 |
>>>>>> On Sat, 06 Dec 2014, Zac Medico wrote: |
| 3 |
> |
| 4 |
>> The PMS people should be *very* interested in any changes to unpack |
| 5 |
>> behavior like this. It supports behavior that will lead to failures for |
| 6 |
>> older versions of portage and other package managers. |
| 7 |
> |
| 8 |
> Some remarks: |
| 9 |
> |
| 10 |
> - The upstream deb2targz program supports only data.tar.gz. Only the |
| 11 |
> Gentoo version has been patched up to support other file types. |
| 12 |
> |
| 13 |
> - There is only a single package in the tree with a dependency on |
| 14 |
> app-arch/deb2targz, and this only on AIX [1]. So on most users' |
| 15 |
> systems deb2targz will not be installed, and "ar x" will be used for |
| 16 |
> unpacking. |
| 17 |
> |
| 18 |
> - Paludis and Pkgcore unconditionally use "ar x" for unpacking. |
| 19 |
> |
| 20 |
> - PMS says [2]: |
| 21 |
> |
| 22 |
> deb packages (*.deb). Ebuilds must ensure that the deb2targz |
| 23 |
> program is installed on those platforms where the GNU binutils |
| 24 |
> ar program is not available and the installed ar program is |
| 25 |
> incompatible with GNU archives. Otherwise, ebuilds must ensure |
| 26 |
> that GNU binutils is installed. |
| 27 |
> |
| 28 |
> One could conclude that GNU binutils ar should be used on platforms |
| 29 |
> where it is available. deb2targz should be used only where ar is |
| 30 |
> incompatible with the GNU version. |
| 31 |
> |
| 32 |
> So in any case, this is a problem of Portage only. I'd suggest to |
| 33 |
> change the logic in unpack() as follows: |
| 34 |
> |
| 35 |
> if <ar is GNU>; then |
| 36 |
> ar x ... |
| 37 |
> elif <deb2targz installed>; then |
| 38 |
> deb2targz ... |
| 39 |
> else |
| 40 |
> ar x ... |
| 41 |
> fi |
| 42 |
> |
| 43 |
> And then the deb2targz case could be patched as proposed. After all, |
| 44 |
> it is only a fallback that should be compatible with "ar x" |
| 45 |
> extraction. |
| 46 |
> |
| 47 |
> Ulrich |
| 48 |
> |
| 49 |
> [1] http://qa-reports.gentoo.org/output/genrdeps/dindex/app-arch/deb2targz |
| 50 |
> [2] http://dev.gentoo.org/~ulm/pms/5/pms.html#x1-14100011.3.3.13 |
| 51 |
|
| 52 |
Okay, so we may want to examine this AIX case more closely, because |
| 53 |
dropping support for AIX would solve our problem with the lack of xz |
| 54 |
support in deb2targz. |
| 55 |
|
| 56 |
Anyway, Brian's patch for xz support with debt2targz appears to be |
| 57 |
compatible with other package managers as well as AIX, so that seems |
| 58 |
like a good way to go. |
| 59 |
-- |
| 60 |
Thanks, |
| 61 |
Zac |
Archives