Re: [gentoo-alt] [PATCH 1/3] scripts/bootstrap-prefix: bugfix: do not arbitrarily overwrite EPREFIX

[Fabian Groffen]

On 31-10-2021 16:39:34 +0100, Etienne Buira wrote:
> EPREFIX is given anyway (as $ROOT) when calling bootstrap-prefix.sh with
> $1 and $2, and a (following) code sets a default value if empty.
> ---
>  scripts/bootstrap-prefix.sh | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/scripts/bootstrap-prefix.sh b/scripts/bootstrap-prefix.sh
> index 0e21c83953..42b116b0e7 100755
> --- a/scripts/bootstrap-prefix.sh
> +++ b/scripts/bootstrap-prefix.sh
> @@ -2306,9 +2306,7 @@ EOF
>  	echo
>  	echo "It seems to me you are '${USER:-$(whoami 2> /dev/null)}' (${UID}), that looks cool to me."
>
> -	# Expect noninteractive users to know what they do:
> -	# Take EPREFIX from argv1 (=ROOT), not from env var.
> -	[[ ${TODO} == 'noninteractive' ]] && EPREFIX=${ROOT}
> +	[[ -z "${EPREFIX}" ]] && EPREFIX="${ROOT}"

can you move this one down to right before the while loop where EPREFIX
is determined (line 2783), and add a brief explanation (comment) before it?

While at it, can you please shorten the subject of the commit message to
fit within 80 chars?

Thanks,
Fabian
>
>  	echo
>  	echo "I'm going to check for some variables in your environment now:"
>

-- 
Fabian Groffen
Gentoo on a different level