1 |
Hi Fabian, |
2 |
|
3 |
Thanks for the quick response. |
4 |
|
5 |
On Tue, 18 Oct 2011 20:13:14 +0200 |
6 |
Fabian Groffen <grobian@g.o> wrote: |
7 |
|
8 |
> On 18-10-2011 20:10:24 +0200, Burcin Erocal wrote: |
9 |
> > Attached trivial patch puts this check in an if statement depending |
10 |
> > on an environment variable QA_SKIP_WRITABLE. Setting this in |
11 |
> > make.conf makes prefix usable again. |
12 |
> |
13 |
> > diff --git a/bin/misc-functions.sh b/bin/misc-functions.sh |
14 |
> > --- a/bin/misc-functions.sh |
15 |
> > +++ b/bin/misc-functions.sh |
16 |
> > @@ -168,6 +168,7 @@ |
17 |
> > fi |
18 |
> > |
19 |
> > # Now we look for all world writable files. |
20 |
> > + if [ "${QA_SKIP_WRITABLE-unset}" == unset ] ; then |
21 |
> > local i |
22 |
> > for i in $(find "${D}/" -type f -perm -2); do |
23 |
> |
24 |
> How would this work, if you changed the D into ED here? Checking |
25 |
> files outside of our control is indeed not really useful. |
26 |
|
27 |
In that context, printing $D gives $PORTAGE_TMP/$CATEGORY/$P/image in |
28 |
the prefix. Since these are the new files introduced by the ebuild, I |
29 |
don't think we need to change that line. Note that this is already in |
30 |
the portage sources and I didn't touch it. :) |
31 |
|
32 |
Cheers, |
33 |
Burcin |