Re: [gentoo-alt] Allow non-interactive bootstrap to be stopped at arbitrary stages

[Benda Xu]

Hi Sam,

Sam Pfeiffer <sammypfeiffer@×××××.com> writes:

> To be more specific... To easily go thru it I made a gist with the
> latest version of bootstrap-prefix.sh and I'll be pointing to specific
> lines (this also helps me recap why I did this, as I remember using
> stage{1,2,3} didn't work for me when I first came into this):
>
> When you execute bootstrap-prefix.sh without arguments (other than the
> EPREFIX, ./bootstrap-prefix.sh /MY/EPREFIX) it calls this line:
> https://gist.github.com/awesomebytes/ba4df9c6ef3ab5742cb9aceed7998c3d#file-bootstrap-prefix-sh-L3033
> Calling bootstrap_interactive
>
> If you give an extra argument (./bootstrap-prefix.sh /MY/EPREFIX
> [noninteractive, stage{1,2,3}]) it calls this line:
> https://gist.github.com/awesomebytes/ba4df9c6ef3ab5742cb9aceed7998c3d#file-bootstrap-prefix-sh-L3082
> bootstrap_${TODO#non} || exit 1
>
> Which, on the noninteractive case, goes to the same place than no
> arguments (bootstrap_interactive). But in the stage{1,2,3} calls
> directly the bootstrap_stageX function.
>
> The thing is, noninteractive does some checks, finds resources and
> sets up environment variables like:
>
> * Check for bad flags:
> https://gist.github.com/awesomebytes/ba4df9c6ef3ab5742cb9aceed7998c3d#file-bootstrap-prefix-sh-L2200-L2247
> * We find a gcc:
> https://gist.github.com/awesomebytes/ba4df9c6ef3ab5742cb9aceed7998c3d#file-bootstrap-prefix-sh-L2273-L2433
> * We get a cpu count and adjust -j for Make:
> https://gist.github.com/awesomebytes/ba4df9c6ef3ab5742cb9aceed7998c3d#file-bootstrap-prefix-sh-L2443-L2501
> * Check if we deal with multilib systems:
> https://gist.github.com/awesomebytes/ba4df9c6ef3ab5742cb9aceed7998c3d#file-bootstrap-prefix-sh-L2503-L2576
> * Check if we are boostrapping from a Gentoo system:
> https://gist.github.com/awesomebytes/ba4df9c6ef3ab5742cb9aceed7998c3d#file-bootstrap-prefix-sh-L2578-L2608
> * Set our EPREFIX:
> https://gist.github.com/awesomebytes/ba4df9c6ef3ab5742cb9aceed7998c3d#file-bootstrap-prefix-sh-L2610-L2681
>
> Which is summarised at the end by setting the environment variables EPREFIX, CHOST, PATH, MAKEOPTS.
>
> And then finally calls bootstrap_stage1_log, which runs
> bootstrap_stage1 itself.
> https://gist.github.com/awesomebytes/ba4df9c6ef3ab5742cb9aceed7998c3d#file-bootstrap-prefix-sh-L2724-L2726
>
> Then, we compare with calling bootstrap-prefix.sh EPREFIX stage1...
> Calls bootstrap_stage1():
> https://gist.github.com/awesomebytes/ba4df9c6ef3ab5742cb9aceed7998c3d#file-bootstrap-prefix-sh-L1355
>
> And as you can see it won't do any of the extra work done in
> bootstrap_interactive().

Perfect! You are correct in understanding the script.

> I'm not that versed in this script, so I may be missing something easy
> to overcome this (or I don't know enough about what is going on), but
> there is no separate function that does everything in
> bootstrap_interactive without calling bootstrap_stage1. And
> bootstrap_stage1 does not do all that setup that bootstrap_interactive
> does. So that's how I came to my proposal.
>
> If there is some patch to enable that setup from bootstrap_interactive
> with bootstrap_stage1, that would be a good alternative, I guess. I
> still like the fact that with my approach you are just saying
> "bootstrap everything until this step" instead of needing to manually
> do bootstrap_setup (imaginary function I just named) then
> bootstrap_stage1, then bootstrap_stage2, then bootstrap_stage3, and
> then no argument for the last emerge -e system, to get to a specific
> bootstrap stage, but that's just commodity.

Why manually do bootstrap_setup then stage 1-3, emerge -e @system a bad
thing?  That gives you more control of what to do in the CI system.  I
would prefer to have the explicit steps than environmental switches.

> Let me know if I'm wrong somewhere or you think of any better solution!

You are nowhere wrong.  I just prefer keeping the manual bootstrap
options up to date and have it drive our CI.

Yours,
Benda