1 |
Hi Alan, |
2 |
|
3 |
On 10/06/2011 12:33 AM, Alan Hourihane wrote: |
4 |
> On 10/05/11 22:39, Jonathan Callen wrote: |
5 |
>> On 10/05/2011 03:01 PM, Alan Hourihane wrote: |
6 |
>>> On 10/04/11 11:24, Alan Hourihane wrote: |
7 |
>>>> On 10/04/11 11:21, Alan Hourihane wrote: |
8 |
>>>>> On 08/14/11 19:05, Alan Hourihane wrote: |
9 |
>>>>>> On 08/14/11 11:40, Fabian Groffen wrote: |
10 |
>>>>>>> On 07-07-2011 15:42:40 +0100, Alan Hourihane wrote: |
11 |
>>>>>>>> Hi all, |
12 |
>>>>>>>> |
13 |
>>>>>>>> Can someone replace the link the cmake eclass that says |
14 |
>>>>>>>> .... |
15 |
>>>>>>>> |
16 |
>>>>>>>> if use prefix; then |
17 |
>>>>>>>> |
18 |
>>>>>>>> to |
19 |
>>>>>>>> |
20 |
>>>>>>>> if use prefix && ! EPREFIX=; then |
21 |
>>>>> |
22 |
>>>> if use prefix && "${EPREFIX}" != ""; then |
23 |
>>>> |
24 |
>>>> The above is better. Can this be committed ? |
25 |
>>>> |
26 |
>> |
27 |
>>> Actually this works for me..... |
28 |
>> |
29 |
>>> if use prefix && ! ${EPREFIX}; then |
30 |
>> |
31 |
>> I hope you meant: |
32 |
>> |
33 |
>> if use prefix && ! [[ ${EPREFIX} ]]; then |
34 |
|
35 |
Reading the different variants (without reading the cmake.eclass), |
36 |
these variants do give different results. |
37 |
|
38 |
Probably, you do want to fire that 'if' when "EPREFIX is not empty", right? |
39 |
|
40 |
Actually, the last one (as reported in [1]) does fire "when EPREFIX is empty". |
41 |
|
42 |
So you probably want: |
43 |
|
44 |
- if use prefix; then |
45 |
+ if use prefix && [[ ${EPREFIX} ]]; then |
46 |
|
47 |
So - have you actually tried your reported variant? |
48 |
|
49 |
<pointless optimization> |
50 |
Given that EPREFIX is set with 'use prefix' only, it could also read: |
51 |
|
52 |
- if use prefix; then |
53 |
+ if [[ ${EPREFIX} ]]; then |
54 |
</pointless optimization> |
55 |
|
56 |
OTOH: Do we support non-empty EPREFIX on FreeMiNT? |
57 |
|
58 |
[1] https://bugs.gentoo.org/show_bug.cgi?id=385839 |
59 |
|
60 |
/haubi/ |